test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Zhu, ShuaiX" <shuaix.zhu@intel.com>
To: "Ma, LihongX" <lihongx.ma@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Ma, LihongX" <lihongx.ma@intel.com>,
	"Zhu, ShuaiX" <shuaix.zhu@intel.com>
Subject: Re: [dts] [PATCH V1 1/3][scapy vxlan] dep/vxlan: modify class name from	Vxlan to VXLAN
Date: Tue, 23 Jul 2019 09:13:26 +0000	[thread overview]
Message-ID: <4DC48DF9BDA3E54A836D2D3C057DEC6F0B1C4424@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1563843053-30184-1-git-send-email-lihongx.ma@intel.com>

Tested-by: Zhu, ShuaiX <shuaix.zhu@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Tuesday, July 23, 2019 8:51 AM
> To: dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1 1/3][scapy vxlan] dep/vxlan: modify class name from
> Vxlan to VXLAN
> 
> from scapy 2.3.3, the vxlan is supported by default, so unify the class name
> between high version and low version.
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  dep/vxlan.py | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/dep/vxlan.py b/dep/vxlan.py index 8fc914b..d160718 100644
> --- a/dep/vxlan.py
> +++ b/dep/vxlan.py
> @@ -13,16 +13,16 @@ vxlanmagic = "0x8"
> 
>  VXLAN_PORT=4789
> 
> -class Vxlan(Packet):
> -    name = "Virtual eXtensible Local Area Network"
> -    fields_desc = [ByteField("flag", 8),
> +class VXLAN(Packet):
> +    name = "VXLAN"
> +    fields_desc = [ByteField("flags", 8),
>                     X3BytesField("reserved1", 0),
>                     X3BytesField("vni", 0),
>                     ByteField("reserved2", 0)]
> 
>      def guess_payload_class(self, payload):
>          if self.flag == vxlanmagic:
> -            return Vxlan
> +            return VXLAN
>          else:
>              return Packet.guess_payload_class(self, payload)
> 
> @@ -30,5 +30,5 @@ class Vxlan(Packet):
>          return self.sprintf("VXLAN (vni=%VXLAN.vni%)")
> 
>  split_layers(UDP, DNS, sport=53)
> -bind_layers(UDP, Vxlan, dport=VXLAN_PORT) -bind_layers(Vxlan, Ether)
> +bind_layers(UDP, VXLAN, dport=VXLAN_PORT) bind_layers(VXLAN, Ether)
> --
> 2.7.4


      parent reply	other threads:[~2019-07-23  9:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23  0:50 lihong
2019-07-23  0:50 ` [dts] [PATCH V1 2/3][scapy vxlan] framework: update vxlan " lihong
2019-07-23  9:13   ` Zhu, ShuaiX
2019-07-23  0:50 ` [dts] [PATCH V1 3/3][scapy vxlan] tests: " lihong
2019-07-23  9:14   ` Zhu, ShuaiX
2019-07-23  9:13 ` Zhu, ShuaiX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC48DF9BDA3E54A836D2D3C057DEC6F0B1C4424@SHSMSX101.ccr.corp.intel.com \
    --to=shuaix.zhu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lihongx.ma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).