From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B7EBF1B10A for ; Thu, 27 Sep 2018 10:50:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2018 01:50:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,309,1534834800"; d="scan'208";a="267143230" Received: from dts-maintain.sh.intel.com (HELO [10.67.119.110]) ([10.67.119.110]) by fmsmga006.fm.intel.com with ESMTP; 27 Sep 2018 01:50:26 -0700 To: "han,yingya" , dts@dpdk.org References: <1537950658-15734-1-git-send-email-yingyax.han@intel.com> From: Lijuan Tu Message-ID: <4da6bd5f-f2ee-aa35-e47d-12c46573a04a@intel.com> Date: Fri, 28 Sep 2018 01:18:30 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1537950658-15734-1-git-send-email-yingyax.han@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dts] [PATCH V1]tests/runtime_queue_number: fix the problemofsending packets and modprobe vfio-pci X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2018 08:50:29 -0000 Applied with comments changed. On 2018年09月26日 16:30, han,yingya wrote: > The code has been modified by referring to other vf-related cases. > 256 exceeded the IP address range. > > Signed-off-by: han,yingya > --- > tests/TestSuite_runtime_queue_number.py | 19 ++++++++++++++++--- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/tests/TestSuite_runtime_queue_number.py b/tests/TestSuite_runtime_queue_number.py > index 44aec06..12263f3 100644 > --- a/tests/TestSuite_runtime_queue_number.py > +++ b/tests/TestSuite_runtime_queue_number.py > @@ -50,6 +50,8 @@ from packet import Packet > > class TestRuntime_Queue_Number(TestCase): > > + supported_vf_driver = ['pci-stub', 'vfio-pci'] > + > def set_up_all(self): > """ > Run at the start of each test suite. > @@ -76,6 +78,17 @@ class TestRuntime_Queue_Number(TestCase): > self.session_third = self.dut.new_session() > self.vf_mac = "00:11:22:33:44:55" > > + # set vf assign method and vf driver > + self.vf_driver = self.get_suite_cfg()['vf_driver'] > + if self.vf_driver is None: > + self.vf_driver = 'pci-stub' > + self.verify(self.vf_driver in self.supported_vf_driver, "Unspported vf driver") > + if self.vf_driver == 'pci-stub': > + self.vf_assign_method = 'pci-assign' > + else: > + self.vf_assign_method = 'vfio-pci' > + self.dut.send_expect('modprobe vfio-pci', '#') > + > def set_up(self): > """ > Run before each test case. > @@ -93,7 +106,7 @@ class TestRuntime_Queue_Number(TestCase): > > try: > for port in self.sriov_vfs_port: > - port.bind_driver(driver="vfio-pci") > + port.bind_driver(self.vf_driver) > except Exception as e: > self.destroy_env() > raise Exception(e) > @@ -125,7 +138,7 @@ class TestRuntime_Queue_Number(TestCase): > """ > self.tester.scapy_foreground() > time.sleep(2) > - for i in range(256): > + for i in range(254): > packet = r'sendp([Ether(dst="%s", src=get_if_hwaddr("%s"))/IP(src="192.168.0.%d", dst="192.168.0.%d")], iface="%s")' % ( > self.vf_mac, itf, i + 1, i + 2, itf) > self.tester.scapy_append(packet) > @@ -160,7 +173,7 @@ class TestRuntime_Queue_Number(TestCase): > m = scanner.search(line) > packet_rec = m.group(1) > > - self.verify(packet_sumnum == int(packet_rec) == 256, "There are some packets lost.") > + self.verify(packet_sumnum == int(packet_rec) == 254, "There are some packets lost.") > > def test_set_valid_vf_max_qn(self): > """