test suite reviews and discussions
 help / color / mirror / Atom feed
From: Lijuan Tu <lijuan.tu@intel.com>
To: Wenjie Li <wenjiex.a.li@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1] tests/ieee1588: set tx-offloads!=0 when start testpmd
Date: Fri, 16 Nov 2018 04:01:45 +0800	[thread overview]
Message-ID: <4df11e08-f82a-16e6-405b-c920a1fe0c90@intel.com> (raw)
In-Reply-To: <1542098119-39335-1-git-send-email-wenjiex.a.li@intel.com>

Applied with change.


On 2018年11月13日 16:35, Wenjie Li wrote:
> For IEEE1588, the full-feature tx path needs to be used.
> Now txq flags is gone in DPDK.
> Start testpmd with "--tx-offloads!=0" to force the tx code path.
>
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>   tests/TestSuite_ieee1588.py | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
> index d9a7b3a..0f3bb98 100644
> --- a/tests/TestSuite_ieee1588.py
> +++ b/tests/TestSuite_ieee1588.py
> @@ -59,7 +59,10 @@ class TestIeee1588(TestCase):
>           self.dut.build_install_dpdk(self.target)
>   
>           self.pmdout = PmdOutput(self.dut)
> -        self.pmdout.start_testpmd("Default")
> +        # For IEEE1588, the full-feature tx path needs to be used.
> +        # Now txq flags is gone in DPDK.
> +        # Start testpmd with "--tx-offloads!=0" to force the tx code path.
> +        self.pmdout.start_testpmd("Default", " --tx-offloads=0x1")
>   
>       def set_up(self):
>           """

      reply	other threads:[~2018-11-15 11:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13  8:35 Wenjie Li
2018-11-15 20:01 ` Lijuan Tu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4df11e08-f82a-16e6-405b-c920a1fe0c90@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=wenjiex.a.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).