From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lijuan.tu@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 8976B4CBB
 for <dts@dpdk.org>; Thu, 15 Nov 2018 12:33:54 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 15 Nov 2018 03:33:53 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.56,236,1539673200"; d="scan'208";a="108294201"
Received: from dts-maintain.sh.intel.com (HELO [10.67.119.110])
 ([10.67.119.110])
 by fmsmga001.fm.intel.com with ESMTP; 15 Nov 2018 03:33:52 -0800
To: Wenjie Li <wenjiex.a.li@intel.com>, dts@dpdk.org
References: <1542098119-39335-1-git-send-email-wenjiex.a.li@intel.com>
From: Lijuan Tu <lijuan.tu@intel.com>
Message-ID: <4df11e08-f82a-16e6-405b-c920a1fe0c90@intel.com>
Date: Fri, 16 Nov 2018 04:01:45 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <1542098119-39335-1-git-send-email-wenjiex.a.li@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [dts] [PATCH V1] tests/ieee1588: set tx-offloads!=0 when start
 testpmd
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Nov 2018 11:33:55 -0000

Applied with change.


On 2018年11月13日 16:35, Wenjie Li wrote:
> For IEEE1588, the full-feature tx path needs to be used.
> Now txq flags is gone in DPDK.
> Start testpmd with "--tx-offloads!=0" to force the tx code path.
>
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>   tests/TestSuite_ieee1588.py | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
> index d9a7b3a..0f3bb98 100644
> --- a/tests/TestSuite_ieee1588.py
> +++ b/tests/TestSuite_ieee1588.py
> @@ -59,7 +59,10 @@ class TestIeee1588(TestCase):
>           self.dut.build_install_dpdk(self.target)
>   
>           self.pmdout = PmdOutput(self.dut)
> -        self.pmdout.start_testpmd("Default")
> +        # For IEEE1588, the full-feature tx path needs to be used.
> +        # Now txq flags is gone in DPDK.
> +        # Start testpmd with "--tx-offloads!=0" to force the tx code path.
> +        self.pmdout.start_testpmd("Default", " --tx-offloads=0x1")
>   
>       def set_up(self):
>           """