* [PATCH] tests/dual_vlan: Explicitly wait for tcpdump
@ 2023-04-14 12:47 Akihiko Odaki
2023-04-23 8:55 ` lijuan.tu
0 siblings, 1 reply; 2+ messages in thread
From: Akihiko Odaki @ 2023-04-14 12:47 UTC (permalink / raw)
Cc: dts, Akihiko Odaki
It is observed that sometimes tcpdump do not finish writing the packet
dump immediately after killed. Wait for tcpdump to avoid such race.
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
tests/TestSuite_dual_vlan.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
index 70395663..694d4b2e 100644
--- a/tests/TestSuite_dual_vlan.py
+++ b/tests/TestSuite_dual_vlan.py
@@ -197,7 +197,7 @@ class TestDualVlan(TestCase):
def get_tcpdump_package(self):
self.tester.send_expect("killall tcpdump", "#")
- self.tester.send_expect(" ", "#")
+ self.tester.send_expect("wait", "#")
return self.tester.send_expect(
"tcpdump -nn -e -v -r ./getPackageByTcpdump.cap", "#"
)
--
2.40.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] tests/dual_vlan: Explicitly wait for tcpdump
2023-04-14 12:47 [PATCH] tests/dual_vlan: Explicitly wait for tcpdump Akihiko Odaki
@ 2023-04-23 8:55 ` lijuan.tu
0 siblings, 0 replies; 2+ messages in thread
From: lijuan.tu @ 2023-04-23 8:55 UTC (permalink / raw)
To: , Akihiko Odaki; +Cc: dts, Akihiko Odaki
On Fri, 14 Apr 2023 21:47:39 +0900, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
> It is observed that sometimes tcpdump do not finish writing the packet
> dump immediately after killed. Wait for tcpdump to avoid such race.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-23 8:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-14 12:47 [PATCH] tests/dual_vlan: Explicitly wait for tcpdump Akihiko Odaki
2023-04-23 8:55 ` lijuan.tu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).