From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Sun, QinX" <qinx.sun@intel.com>, "dts@dpdk.org" <dts@dpdk.org>,
"Fu, Qi" <qi.fu@intel.com>
Cc: "Sun, QinX" <qinx.sun@intel.com>
Subject: Re: [dts] [PATCH V1] tests/cvl_dcf_flow_priority: modify PPP proto field to byte type
Date: Mon, 12 Jul 2021 03:22:54 +0000 [thread overview]
Message-ID: <543fa3b64eda4733ab1db79278f8b374@intel.com> (raw)
In-Reply-To: <20210706053843.6254-1-qinx.sun@intel.com>
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Qin Sun
> Sent: 2021年7月6日 13:39
> To: dts@dpdk.org
> Cc: Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V1] tests/cvl_dcf_flow_priority: modify PPP proto field to
> byte type
>
> modify PPP proto field to byte type to adapt scapy2.4.4, replace 'insmod xxx'
> with 'modprobe ice' to reduce configure file
>
> Signed-off-by: Qin Sun <qinx.sun@intel.com>
> ---
> tests/TestSuite_cvl_dcf_flow_priority.py | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-) mode change 100644 => 100755
> tests/TestSuite_cvl_dcf_flow_priority.py
>
> diff --git a/tests/TestSuite_cvl_dcf_flow_priority.py
> b/tests/TestSuite_cvl_dcf_flow_priority.py
> old mode 100644
> new mode 100755
> index 532d993..1e9c1f5
> --- a/tests/TestSuite_cvl_dcf_flow_priority.py
> +++ b/tests/TestSuite_cvl_dcf_flow_priority.py
> @@ -1155,11 +1155,8 @@ class CVLDCFFlowPriorityTest(TestCase):
> """
> Run before each test case.
> """
> - self.suite_config = rfc.get_suite_config(self)
> - ice_driver_file_location = self.suite_config["ice_driver_file_location"]
> self.dut.send_expect("rmmod ice","#",30)
> - self.dut.send_expect("insmod %s" % ice_driver_file_location, "# ", 60)
> - time.sleep(10)
> + self.dut.send_expect("modprobe ice","#",30)
@Qi: why reload ice drive in set_up? I think there must be some limitation here.
@Qin, I think ice have been load before , so it is redundant .
>
> def create_testpmd_command(self):
> """
> @@ -1733,7 +1730,7 @@ class CVLDCFFlowPriorityTest(TestCase):
> self.dut.send_expect("flow destroy 0 rule 1", "testpmd> ", 15)
> matched_dic["expect_results"]["expect_pkts"]=0
> self.send_and_check_packets(matched_dic)
> - matched_dic =
> {"scapy_str":['Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=1,type=
> 0x8100)/Dot1Q(vlan=0x2,type=0x8864)/PPPoE(sessionid=0x1)/PPP(proto=0x21)/
> IP()/UDP(dport=23)/("X"*480)'],
> + matched_dic =
> + {"scapy_str":['Ether(dst="00:11:22:33:44:55",type=0x8100)/Dot1Q(vlan=1
> + ,type=0x8100)/Dot1Q(vlan=0x2,type=0x8864)/PPPoE(sessionid=1)/PPP(b\'\\
> + x00\\x21\')/IP()/UDP(dport=23)/("X"*480)'],
> "check_func":{"func":rfc.check_vf_rx_packets_number,
> "param":{"expect_port":2, "expect_queue":"null"}},
> "expect_results":{"expect_pkts":1}}
> --
> 2.25.1
prev parent reply other threads:[~2021-07-12 3:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 5:38 Qin Sun
2021-07-08 6:35 ` Sun, QinX
2021-07-12 3:22 ` Tu, Lijuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543fa3b64eda4733ab1db79278f8b374@intel.com \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=qi.fu@intel.com \
--cc=qinx.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).