From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 37A454CC0 for ; Fri, 2 Mar 2018 03:25:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Mar 2018 18:25:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,409,1515484800"; d="scan'208";a="38639613" Received: from dpdk-test32.sh.intel.com (HELO [10.67.119.122]) ([10.67.119.122]) by orsmga002.jf.intel.com with ESMTP; 01 Mar 2018 18:25:08 -0800 Message-ID: <5A99242E.7020109@intel.com> Date: Fri, 02 Mar 2018 18:15:10 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: michael.luo@intel.com, dts@dpdk.org References: <1518087481-53786-1-git-send-email-michael.luo@intel.com> <1519812923-77663-1-git-send-email-michael.luo@intel.com> In-Reply-To: <1519812923-77663-1-git-send-email-michael.luo@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH v2] tests/pmdrss_hash: check reta_lines before verifying the result X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2018 02:25:11 -0000 Thanks Michael, applied in. On 02/28/2018 06:15 PM, michael.luo@intel.com wrote: > From: Luo Gaoliang > > If reta_lines was empty, DTS shows the test case passed still. > So add the checking of "reta_lines" before verifying result. > And changing the variable "reta_lines" as an argument of verify function > rather than a global variable. > > Signed-off-by: Luo Gaoliang