test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "zhu,shuai" <shuaix.zhu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: juanx.xia@intel.com
Subject: Re: [dts] [PATCH V1] tests/TestSuite_vxlan.py:Stop the port after the csum setting.
Date: Thu, 08 Mar 2018 18:48:07 +0800	[thread overview]
Message-ID: <5AA114E7.9010602@intel.com> (raw)
In-Reply-To: <1518321973-52979-1-git-send-email-shuaix.zhu@intel.com>

Shuai,
Please add signed-off-by and commit log in your patch. You can refer to 
historical patch's format.

Thanks,
Marvin

On 02/11/2018 12:06 PM, zhu,shuai wrote:
> diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
> index 17a34d4..ab9f691 100644
> --- a/tests/TestSuite_vxlan.py
> +++ b/tests/TestSuite_vxlan.py
> @@ -657,11 +657,13 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
>           self.dut.send_expect('vlan set filter off %d' %self.dut_port, "testpmd")
>           # enable tx checksum offload
>           self.dut.send_expect("set fwd csum", "testpmd>", 10)
> +        self.dut.send_expect("port stop all", "testpmd>")
>           self.csum_set_type('ip', self.recv_port)
>           self.csum_set_type('outer-ip', self.recv_port)
>           self.csum_set_type('udp', self.recv_port)
>           self.csum_set_type('tcp', self.recv_port)
>           self.csum_set_type('sctp', self.recv_port)
> +        self.dut.send_expect("port start all", "testpmd>")
>           self.dut.send_expect("csum parse_tunnel on %d" %
>                                self.recv_port, "testpmd>", 10)
>   

  reply	other threads:[~2018-03-08  2:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-11  4:06 zhu,shuai
2018-03-08 10:48 ` Liu, Yong [this message]
2018-03-08  5:24 zhu,shuai
2018-03-08  7:21 [dts] [PATCH V1] tests/TestSuite_vxlan.py Stop " zhu,shuai
2018-03-08  9:30 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5AA114E7.9010602@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=juanx.xia@intel.com \
    --cc=shuaix.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).