test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "zhao,meijuan" <meijuanx.zhao@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1] tests/vf_kernel fix vlan issue
Date: Thu, 08 Mar 2018 18:52:03 +0800	[thread overview]
Message-ID: <5AA115D3.60400@intel.com> (raw)
In-Reply-To: <1518330490-53185-1-git-send-email-meijuanx.zhao@intel.com>

Hi Meijuan,
Please disable vlan filter at end of this case. All test cases are using 
same host setup, we may not want this case affect following cases.

Thanks,
Marvin

On 02/11/2018 02:28 PM, zhao,meijuan wrote:
> add enable vlan filter/strip parameter,
> you can refer to dpdk 8b9bd0
>
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
>   tests/TestSuite_vf_kernel.py | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/tests/TestSuite_vf_kernel.py b/tests/TestSuite_vf_kernel.py
> index c5c150f..af222a8 100644
> --- a/tests/TestSuite_vf_kernel.py
> +++ b/tests/TestSuite_vf_kernel.py
> @@ -399,6 +399,8 @@ class TestVfKernel(TestCase):
>           verify add/delete vlan
>           """
>           vlan_ids = random.randint(1, 4095)
> +        self.dut_testpmd.execute_cmd("vlan set filter on 0")
> +        self.dut_testpmd.execute_cmd("vlan set strip on 0")
>           self.vm0_dut.send_expect("ifconfig %s up" % self.vm0_intf0, "#")
>           vm0_vf0_mac = self.vm0_dut.ports_info[0]['port'].get_mac_addr()
>   

  reply	other threads:[~2018-03-08  3:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-11  6:28 zhao,meijuan
2018-03-08 10:52 ` Liu, Yong [this message]
2018-03-08  8:10 zhao,meijuan
2018-03-08 17:27 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5AA115D3.60400@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=meijuanx.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).