test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "xu,gang" <gangx.xu@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V3] add tx-offloads value to start testpmd
Date: Thu, 08 Mar 2018 19:32:02 +0800	[thread overview]
Message-ID: <5AA11F32.4090606@intel.com> (raw)
In-Reply-To: <1520322754-70844-1-git-send-email-gangx.xu@intel.com>

Gang,
This suite is not related to csum, why you add csum tx offload flag?

Thanks,
Marvin

On 03/06/2018 03:52 PM, xu,gang wrote:
> open DEV_TX_OFFLOAD_TCP_CKSUM options
>
> Signed-off-by: xu,gang <gangx.xu@intel.com>
> ---
>   tests/TestSuite_scatter.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py
> index 74fc08f..31f400d 100644
> --- a/tests/TestSuite_scatter.py
> +++ b/tests/TestSuite_scatter.py
> @@ -105,7 +105,7 @@ class TestScatter(TestCase):
>           """
>           out = self.pmdout.start_testpmd(
>               "1S/2C/1T", "--mbcache=200 --mbuf-size=%d --portmask=0x1 "
> -            "--max-pkt-len=9000 --port-topology=loop" % (self.mbsize))
> +            "--max-pkt-len=9000 --port-topology=loop --tx-offloads=0x00000008" % (self.mbsize))
>   
>           self.verify("Error" not in out, "launch error 1")
>   

  reply	other threads:[~2018-03-08  3:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06  7:52 xu,gang
2018-03-08 11:32 ` Liu, Yong [this message]
2018-06-13  9:00 xu,gang
2018-06-14  8:34 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5AA11F32.4090606@intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=gangx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).