test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/vf_kernel fix vlan issue
@ 2018-03-08  8:10 zhao,meijuan
  2018-03-08 17:27 ` Liu, Yong
  0 siblings, 1 reply; 4+ messages in thread
From: zhao,meijuan @ 2018-03-08  8:10 UTC (permalink / raw)
  To: dts; +Cc: zhao,meijuan

add enable vlan filter/strip parameter, you can refer to dpdk 8b9bd0

Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
 tests/TestSuite_vf_kernel.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/TestSuite_vf_kernel.py b/tests/TestSuite_vf_kernel.py
index c5c150f..06ca013 100644
--- a/tests/TestSuite_vf_kernel.py
+++ b/tests/TestSuite_vf_kernel.py
@@ -399,6 +399,8 @@ class TestVfKernel(TestCase):
         verify add/delete vlan
         """
         vlan_ids = random.randint(1, 4095)
+        self.dut_testpmd.execute_cmd("vlan set filter on 0")
+        self.dut_testpmd.execute_cmd("vlan set strip on 0")
         self.vm0_dut.send_expect("ifconfig %s up" % self.vm0_intf0, "#")
         vm0_vf0_mac = self.vm0_dut.ports_info[0]['port'].get_mac_addr()
 
@@ -440,6 +442,7 @@ class TestVfKernel(TestCase):
         else:
             self.verify(self.verify_vm_tcpdump(self.vm0_dut, self.vm0_intf0,
                                                vm0_vf0_mac, vlan_id='%d' % vlan_ids) == False, "delete vlan error")
+        self.dut_testpmd.execute_cmd("vlan set filter off 0")
 
     def test_packet_statistic(self):
         """
-- 
1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/vf_kernel fix vlan issue
  2018-03-08  8:10 [dts] [PATCH V1] tests/vf_kernel fix vlan issue zhao,meijuan
@ 2018-03-08 17:27 ` Liu, Yong
  0 siblings, 0 replies; 4+ messages in thread
From: Liu, Yong @ 2018-03-08 17:27 UTC (permalink / raw)
  To: zhao,meijuan, dts

Thanks, Meijuan. Applied.

On 03/08/2018 04:10 PM, zhao,meijuan wrote:
> add enable vlan filter/strip parameter, you can refer to dpdk 8b9bd0
>
> Signed-off-by: zhao,meijuan<meijuanx.zhao@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/vf_kernel fix vlan issue
  2018-02-11  6:28 zhao,meijuan
@ 2018-03-08 10:52 ` Liu, Yong
  0 siblings, 0 replies; 4+ messages in thread
From: Liu, Yong @ 2018-03-08 10:52 UTC (permalink / raw)
  To: zhao,meijuan, dts

Hi Meijuan,
Please disable vlan filter at end of this case. All test cases are using 
same host setup, we may not want this case affect following cases.

Thanks,
Marvin

On 02/11/2018 02:28 PM, zhao,meijuan wrote:
> add enable vlan filter/strip parameter,
> you can refer to dpdk 8b9bd0
>
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
>   tests/TestSuite_vf_kernel.py | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/tests/TestSuite_vf_kernel.py b/tests/TestSuite_vf_kernel.py
> index c5c150f..af222a8 100644
> --- a/tests/TestSuite_vf_kernel.py
> +++ b/tests/TestSuite_vf_kernel.py
> @@ -399,6 +399,8 @@ class TestVfKernel(TestCase):
>           verify add/delete vlan
>           """
>           vlan_ids = random.randint(1, 4095)
> +        self.dut_testpmd.execute_cmd("vlan set filter on 0")
> +        self.dut_testpmd.execute_cmd("vlan set strip on 0")
>           self.vm0_dut.send_expect("ifconfig %s up" % self.vm0_intf0, "#")
>           vm0_vf0_mac = self.vm0_dut.ports_info[0]['port'].get_mac_addr()
>   

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V1] tests/vf_kernel fix vlan issue
@ 2018-02-11  6:28 zhao,meijuan
  2018-03-08 10:52 ` Liu, Yong
  0 siblings, 1 reply; 4+ messages in thread
From: zhao,meijuan @ 2018-02-11  6:28 UTC (permalink / raw)
  To: dts; +Cc: zhao,meijuan

add enable vlan filter/strip parameter,
you can refer to dpdk 8b9bd0

Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
 tests/TestSuite_vf_kernel.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/TestSuite_vf_kernel.py b/tests/TestSuite_vf_kernel.py
index c5c150f..af222a8 100644
--- a/tests/TestSuite_vf_kernel.py
+++ b/tests/TestSuite_vf_kernel.py
@@ -399,6 +399,8 @@ class TestVfKernel(TestCase):
         verify add/delete vlan
         """
         vlan_ids = random.randint(1, 4095)
+        self.dut_testpmd.execute_cmd("vlan set filter on 0")
+        self.dut_testpmd.execute_cmd("vlan set strip on 0")
         self.vm0_dut.send_expect("ifconfig %s up" % self.vm0_intf0, "#")
         vm0_vf0_mac = self.vm0_dut.ports_info[0]['port'].get_mac_addr()
 
-- 
1.9.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-03-08  9:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-08  8:10 [dts] [PATCH V1] tests/vf_kernel fix vlan issue zhao,meijuan
2018-03-08 17:27 ` Liu, Yong
  -- strict thread matches above, loose matches on Subject: below --
2018-02-11  6:28 zhao,meijuan
2018-03-08 10:52 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).