test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1]tests/userspace_ethtool: fix FVL filter Rx vlan packet failure
@ 2018-04-11  6:43 han,yingya
  2018-04-16 13:01 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: han,yingya @ 2018-04-11  6:43 UTC (permalink / raw)
  To: dts; +Cc: han,yingya

FVL port statistic is retrieved from register.
Those filtered packets still will be calculated in.
Transmitted packets number can be used to track the number of actually received packets.

Signed-off-by: han,yingya <yingyax.han@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 84b1f1e..2d2199c 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -442,8 +442,8 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
             pkt.config_layer('vlan', {'vlan': wrong_vlan})
             pkt.send_pkt(tx_port=intf)
             time.sleep(2)
-            rx_pkts_wrong, _ = self.strip_portstats(port)
-            self.verify(rx_pkts_wrong == rx_pkts, "Failed to filter Rx vlan packet")
+            rx_pkts_wrong, tx_pkts_wrong = self.strip_portstats(port)
+            self.verify(tx_pkts_wrong == rx_pkts, "Failed to filter Rx vlan packet")
 
             # remove vlan
             self.dut.send_expect("vlan %d del %d" % (index, vlan), "EthApp>")
@@ -451,8 +451,8 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
             pkt.config_layer('vlan', {'vlan': vlan})
             pkt.send_pkt(tx_port=intf)
             time.sleep(2)
-            rx_pkts_del, _ = self.strip_portstats(port)
-            self.verify(rx_pkts_del == rx_pkts, "Failed to remove Rx vlan filter")
+            rx_pkts_del, tx_pkts_del = self.strip_portstats(port)
+            self.verify(tx_pkts_del == rx_pkts, "Failed to remove Rx vlan filter")
 
         self.dut.send_expect("quit", "# ")
         self.dut.send_expect("sed -i -e '/hw_vlan_filter=1;$/d' %s" % main_file, "# ")
-- 
1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1]tests/userspace_ethtool: fix FVL filter Rx vlan packet failure
  2018-04-11  6:43 [dts] [PATCH V1]tests/userspace_ethtool: fix FVL filter Rx vlan packet failure han,yingya
@ 2018-04-16 13:01 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2018-04-16 13:01 UTC (permalink / raw)
  To: han,yingya, dts

Thanks, yingya. Applied.

On 04/11/2018 02:43 PM, han,yingya wrote:
> FVL port statistic is retrieved from register.
> Those filtered packets still will be calculated in.
> Transmitted packets number can be used to track the number of actually received packets.
>
> Signed-off-by: han,yingya<yingyax.han@intel.com>
> ---

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-16  5:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-11  6:43 [dts] [PATCH V1]tests/userspace_ethtool: fix FVL filter Rx vlan packet failure han,yingya
2018-04-16 13:01 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).