test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] remove devargs unit tests
@ 2018-05-25  9:06 xu,gang
  2018-05-25 16:58 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: xu,gang @ 2018-05-25  9:06 UTC (permalink / raw)
  To: dts; +Cc: xu,gang

reference dpdk commit 83945fbd7c4954c1cfad320eb28c0dcbd5087bb3
remove devargs unit tests
The current test will not be compatible anymore with a private devargs list.
Moreover, the new functions should have new tests, while the existing
API will be removed.
The current unit tests are thus obsolete and hereby removed.


Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 tests/TestSuite_unit_tests_eal.py | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
index b619572..68a4cbe 100644
--- a/tests/TestSuite_unit_tests_eal.py
+++ b/tests/TestSuite_unit_tests_eal.py
@@ -339,16 +339,6 @@ class TestUnitTestsEal(TestCase):
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Test failed")
 
-    def test_devargs(self):
-        """
-        Run devargs autotest.
-        """
-
-        self.dut.send_expect(self.test_app_cmdline, "R.*T.*E.*>.*>", self.start_test_time)
-        out = self.dut.send_expect("devargs_autotest", "RTE>>", self.run_cmd_time)
-        self.dut.send_expect("quit", "# ")
-        self.verify("Test OK" in out, "Test failed")
-
     def test_kvargs(self):
         """
         Run kvargs autotest.
-- 
1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] remove devargs unit tests
  2018-05-25  9:06 [dts] [PATCH V1] remove devargs unit tests xu,gang
@ 2018-05-25 16:58 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2018-05-25 16:58 UTC (permalink / raw)
  To: xu,gang, dts

Thanks, Gang. Applied.

On 05/25/2018 05:06 PM, xu,gang wrote:
> reference dpdk commit 83945fbd7c4954c1cfad320eb28c0dcbd5087bb3
> remove devargs unit tests
> The current test will not be compatible anymore with a private devargs list.
> Moreover, the new functions should have new tests, while the existing
> API will be removed.
> The current unit tests are thus obsolete and hereby removed.
>
>
> Signed-off-by: xu,gang<gangx.xu@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-25  9:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-25  9:06 [dts] [PATCH V1] remove devargs unit tests xu,gang
2018-05-25 16:58 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).