test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2] fix vlan filter off in invalid
@ 2018-06-11  6:29 xu,gang
  2018-07-11  9:57 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: xu,gang @ 2018-06-11  6:29 UTC (permalink / raw)
  To: dts; +Cc: xu,gang

Before the dpdk commit 8b9bd0efe0b6920a08e28eebacf2bb916bdf5653
VLAN filter and VLAN strip are enabled in testpmd by default.
But since this commit ,they are disabled by default.
so "vlam set filter off 0" can't be expected, need "vlan set filter on 0" first


Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 tests/TestSuite_generic_filter.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py
index e69246b..6142c64 100644
--- a/tests/TestSuite_generic_filter.py
+++ b/tests/TestSuite_generic_filter.py
@@ -102,8 +102,14 @@ class TestGeneric_filter(TestCase):
                 "vlan set strip off %s" % valports[0], "testpmd> ")
             self.dut.send_expect(
                 "vlan set strip off %s" % valports[1], "testpmd> ")
+            #reson dpdk-5315
+            self.dut.send_expect(
+                "vlan set filter on %s" % valports[0], "testpmd> ")
             self.dut.send_expect(
                 "vlan set filter off %s" % valports[0], "testpmd> ")
+            #reson dpdk-5315
+            self.dut.send_expect(
+                "vlan set filter on %s" % valports[1], "testpmd> ")
             self.dut.send_expect(
                 "vlan set filter off %s" % valports[1], "testpmd> ")
 
-- 
1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V2] fix vlan filter off in invalid
  2018-06-11  6:29 [dts] [PATCH V2] fix vlan filter off in invalid xu,gang
@ 2018-07-11  9:57 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2018-07-11  9:57 UTC (permalink / raw)
  To: xu,gang, dts

Thanks, Gang. Applied.

On 06/11/2018 02:29 PM, xu,gang wrote:
> Before the dpdk commit 8b9bd0efe0b6920a08e28eebacf2bb916bdf5653
> VLAN filter and VLAN strip are enabled in testpmd by default.
> But since this commit ,they are disabled by default.
> so "vlam set filter off 0" can't be expected, need "vlan set filter on 0" first
>
>
> Signed-off-by: xu,gang<gangx.xu@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-11  2:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-11  6:29 [dts] [PATCH V2] fix vlan filter off in invalid xu,gang
2018-07-11  9:57 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).