[dts] [PATCH V1]tests/shutdown_api: fix the crc-strip issue

[dts] [PATCH V1]tests/shutdown_api: fix the crc-strip issue

[han,yingya]

CRC strip has been modified in 1808 and the parameter of "disable-crc-strip" don't take effect.
More details can refer to dpdk commit e557ebc0.

Signed-off-by: han,yingya <yingyax.han@intel.com>
---
 tests/TestSuite_shutdown_api.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 8b6de18..645f5c0 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -263,12 +263,13 @@ class TestShutdownApi(TestCase):
         """
         Reconfigure All Ports With The Same Configurations (CRC)
         """
-        self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket)
+        self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket)
+        self.dut.send_expect("port stop all", "testpmd> ", 100)
+        self.dut.send_expect("port config all crc-strip off", "testpmd> ")
         out = self.dut.send_expect("show config rxtx", "testpmd> ")
         self.verify(
             "Rx offloads=0x0" in out, "CRC stripping not disabled properly")
 
-        self.dut.send_expect("port stop all", "testpmd> ", 100)
         self.dut.send_expect("port config all crc-strip on", "testpmd> ")
         self.dut.send_expect("set fwd mac", "testpmd>")
         self.dut.send_expect("port start all", "testpmd> ", 100)
-- 
1.9.3

Re: [dts] [PATCH V1]tests/shutdown_api: fix the crc-strip issue

[Liu, Yong]

Hi Yingya,
Just from commit log, parameter "disable-crc-strip" is still workable. 
Only new flag DEV_RX_OFFLOAD_KEEP_CRC is added. Could you please check that?

Thanks,
Marvin

On 07/23/2018 05:01 PM, han,yingya wrote:
> CRC strip has been modified in 1808 and the parameter of "disable-crc-strip" don't take effect.
> More details can refer to dpdk commit e557ebc0.
>
> Signed-off-by: han,yingya <yingyax.han@intel.com>
> ---
>   tests/TestSuite_shutdown_api.py | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
> index 8b6de18..645f5c0 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -263,12 +263,13 @@ class TestShutdownApi(TestCase):
>           """
>           Reconfigure All Ports With The Same Configurations (CRC)
>           """
> -        self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket)
> +        self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket)
> +        self.dut.send_expect("port stop all", "testpmd> ", 100)
> +        self.dut.send_expect("port config all crc-strip off", "testpmd> ")
>           out = self.dut.send_expect("show config rxtx", "testpmd> ")
>           self.verify(
>               "Rx offloads=0x0" in out, "CRC stripping not disabled properly")
>   
> -        self.dut.send_expect("port stop all", "testpmd> ", 100)
>           self.dut.send_expect("port config all crc-strip on", "testpmd> ")
>           self.dut.send_expect("set fwd mac", "testpmd>")
>           self.dut.send_expect("port start all", "testpmd> ", 100)