From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id CA4D898 for ; Wed, 25 Jul 2018 05:24:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2018 20:24:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,400,1526367600"; d="scan'208";a="67312843" Received: from dpdk-test32.sh.intel.com (HELO [10.67.119.193]) ([10.67.119.193]) by FMSMGA003.fm.intel.com with ESMTP; 24 Jul 2018 20:24:19 -0700 Message-ID: <5B585A5E.9060409@intel.com> Date: Wed, 25 Jul 2018 19:09:18 +0800 From: "Liu, Yong" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "han,yingya" , dts@dpdk.org References: <1532336461-89611-1-git-send-email-yingyax.han@intel.com> In-Reply-To: <1532336461-89611-1-git-send-email-yingyax.han@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dts] [PATCH V1]tests/shutdown_api: fix the crc-strip issue X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 03:24:22 -0000 Hi Yingya, Just from commit log, parameter "disable-crc-strip" is still workable. Only new flag DEV_RX_OFFLOAD_KEEP_CRC is added. Could you please check that? Thanks, Marvin On 07/23/2018 05:01 PM, han,yingya wrote: > CRC strip has been modified in 1808 and the parameter of "disable-crc-strip" don't take effect. > More details can refer to dpdk commit e557ebc0. > > Signed-off-by: han,yingya > --- > tests/TestSuite_shutdown_api.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py > index 8b6de18..645f5c0 100644 > --- a/tests/TestSuite_shutdown_api.py > +++ b/tests/TestSuite_shutdown_api.py > @@ -263,12 +263,13 @@ class TestShutdownApi(TestCase): > """ > Reconfigure All Ports With The Same Configurations (CRC) > """ > - self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket) > + self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket) > + self.dut.send_expect("port stop all", "testpmd> ", 100) > + self.dut.send_expect("port config all crc-strip off", "testpmd> ") > out = self.dut.send_expect("show config rxtx", "testpmd> ") > self.verify( > "Rx offloads=0x0" in out, "CRC stripping not disabled properly") > > - self.dut.send_expect("port stop all", "testpmd> ", 100) > self.dut.send_expect("port config all crc-strip on", "testpmd> ") > self.dut.send_expect("set fwd mac", "testpmd>") > self.dut.send_expect("port start all", "testpmd> ", 100)