test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2]tests/shutdown_api: fix the crc-strip issue
@ 2018-08-02  6:58 han,yingya
  2018-08-06 13:25 ` Liu, Yong
  0 siblings, 1 reply; 2+ messages in thread
From: han,yingya @ 2018-08-02  6:58 UTC (permalink / raw)
  To: dts; +Cc: han,yingya

The "disable-crc-strip" parameter was modified in dpdk 18.08.
The expected value for RX_offloads when crc-strip is off is 0x10000 and when crc-strip is on is 0x1000.
More details can refer to dpdk commit e557ebc0 and DPDK-5829.


Signed-off-by: han,yingya <yingyax.han@intel.com>
---
 tests/TestSuite_shutdown_api.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index d00c3fb..52a8fbf 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -266,7 +266,7 @@ class TestShutdownApi(TestCase):
         self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket)
         out = self.dut.send_expect("show config rxtx", "testpmd> ")
         self.verify(
-            "Rx offloads=0x0" in out, "CRC stripping not disabled properly")
+            "Rx offloads=0x10000" in out, "CRC keeping not enabled properly")
 
         self.dut.send_expect("port stop all", "testpmd> ", 100)
         self.dut.send_expect("port config all crc-strip on", "testpmd> ")
-- 
1.9.3

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V2]tests/shutdown_api: fix the crc-strip issue
  2018-08-02  6:58 [dts] [PATCH V2]tests/shutdown_api: fix the crc-strip issue han,yingya
@ 2018-08-06 13:25 ` Liu, Yong
  0 siblings, 0 replies; 2+ messages in thread
From: Liu, Yong @ 2018-08-06 13:25 UTC (permalink / raw)
  To: han,yingya, dts

Thanks, Yingya. Applied.

On 08/02/2018 02:58 PM, han,yingya wrote:
> The "disable-crc-strip" parameter was modified in dpdk 18.08.
> The expected value for RX_offloads when crc-strip is off is 0x10000 and when crc-strip is on is 0x1000.
> More details can refer to dpdk commit e557ebc0 and DPDK-5829.
>
>
> Signed-off-by: han,yingya<yingyax.han@intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-08-06  5:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-02  6:58 [dts] [PATCH V2]tests/shutdown_api: fix the crc-strip issue han,yingya
2018-08-06 13:25 ` Liu, Yong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).