test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/ip_pipeline: optimize scripts
@ 2022-06-16  7:14 Jiale Song
  2022-06-21  6:54 ` lijuan.tu
  0 siblings, 1 reply; 2+ messages in thread
From: Jiale Song @ 2022-06-16  7:14 UTC (permalink / raw)
  To: dts; +Cc: Jiale Song

optimize 2 issue:
  1.the app should be closed after the case test, otherwise the
execution of other cases will be affected.
  2.sometimes the port link status changes slowly. need to ensure that
the port link status is up before sending the package.


Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_ip_pipeline.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_ip_pipeline.py b/tests/TestSuite_ip_pipeline.py
index ab1637b5..be9c05b9 100644
--- a/tests/TestSuite_ip_pipeline.py
+++ b/tests/TestSuite_ip_pipeline.py
@@ -103,6 +103,8 @@ class TestIPPipeline(TestCase):
 
         self.tcpdump_start_sniff(rx_interface, filters)
 
+        # check that the link status of the port sending the packet is up
+        self.tester.is_interface_up(tx_interface)
         # Prepare the pkts to be sent
         self.tester.scapy_foreground()
         self.tester.scapy_append('pkt = rdpcap("%s")' % (pcap_file))
@@ -1036,7 +1038,8 @@ class TestIPPipeline(TestCase):
         """
         Run after each test case.
         """
-        pass
+        # close app
+        self.dut.send_expect("^C", "# ")
 
     def tear_down_all(self):
         """
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dts] [PATCH V1] tests/ip_pipeline: optimize scripts
  2022-06-16  7:14 [dts] [PATCH V1] tests/ip_pipeline: optimize scripts Jiale Song
@ 2022-06-21  6:54 ` lijuan.tu
  0 siblings, 0 replies; 2+ messages in thread
From: lijuan.tu @ 2022-06-21  6:54 UTC (permalink / raw)
  To: dts, Jiale Song; +Cc: Jiale Song

On Thu, 16 Jun 2022 15:14:48 +0800, Jiale Song <songx.jiale@intel.com> wrote:
> optimize 2 issue:
>   1.the app should be closed after the case test, otherwise the
> execution of other cases will be affected.
>   2.sometimes the port link status changes slowly. need to ensure that
> the port link status is up before sending the package.
> 
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>


Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-21  6:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-16  7:14 [dts] [PATCH V1] tests/ip_pipeline: optimize scripts Jiale Song
2022-06-21  6:54 ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).