test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1 6/6] tests/dpdk_gso_lib: modify dpdk code by dpdk change
@ 2022-06-24  5:32 Wei Ling
  2022-06-24  6:48 ` He, Xingguang
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Wei Ling @ 2022-06-24  5:32 UTC (permalink / raw)
  To: dts; +Cc: Wei Ling

According to the dpdk commit 1945c64674(app/testpmd: perform SW IP
checksum for GRO/GSO packets) and commit 8ba1723783(net/vhost:
perform SW checksum in Tx path), no need to modify DPDK code to test.

Signed-off-by: Wei Ling <weix.ling@intel.com>
---
 tests/TestSuite_dpdk_gso_lib.py | 25 -------------------------
 1 file changed, 25 deletions(-)

diff --git a/tests/TestSuite_dpdk_gso_lib.py b/tests/TestSuite_dpdk_gso_lib.py
index ee71bcd6..9a43eae8 100644
--- a/tests/TestSuite_dpdk_gso_lib.py
+++ b/tests/TestSuite_dpdk_gso_lib.py
@@ -79,7 +79,6 @@ class TestDPDKGsoLib(TestCase):
         else:
             self.socket_mem = "1024,1024"
 
-        self.prepare_dpdk()
         self.base_dir = self.dut.base_dir.replace("~", "/root")
 
     def set_up(self):
@@ -187,29 +186,6 @@ class TestDPDKGsoLib(TestCase):
         )
         self.dut.send_expect("ip netns exec ns1 ifconfig gre100 1.1.1.1/24 up", "#")
 
-    def prepare_dpdk(self):
-        # Changhe the testpmd checksum fwd code for mac change
-        self.dut.send_expect(
-            "cp ./app/test-pmd/csumonly.c ./app/test-pmd/csumonly_backup.c", "#"
-        )
-        self.dut.send_expect(
-            "sed -i '/ether_addr_copy(&peer_eth/i\#if 0' ./app/test-pmd/csumonly.c", "#"
-        )
-        self.dut.send_expect(
-            "sed -i '/parse_ethernet(eth_hdr, &info/i\#endif' ./app/test-pmd/csumonly.c",
-            "#",
-        )
-        self.dut.build_install_dpdk(self.dut.target)
-
-    def unprepare_dpdk(self):
-        # Recovery the DPDK code to original
-        time.sleep(5)
-        self.dut.send_expect(
-            "cp ./app/test-pmd/csumonly_backup.c ./app/test-pmd/csumonly.c ", "#"
-        )
-        self.dut.send_expect("rm -rf ./app/test-pmd/csumonly_backup.c", "#")
-        self.dut.build_install_dpdk(self.dut.target)
-
     def set_vm_cpu_number(self, vm_config):
         # config the vcpu numbers = 1
         # config the cpupin only have one core
@@ -517,7 +493,6 @@ class TestDPDKGsoLib(TestCase):
         for i in self.dut_ports:
             port = self.dut.ports_info[i]["port"]
             port.bind_driver(self.def_driver)
-        self.unprepare_dpdk()
         self.dut.send_expect("ip netns del ns1", "#", 30)
         self.dut.send_expect("./usertools/dpdk-devbind.py -u %s" % (self.pci), "# ", 30)
         self.dut.send_expect(
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [dts][PATCH V1 6/6] tests/dpdk_gso_lib: modify dpdk code by dpdk change
  2022-06-24  5:32 [dts][PATCH V1 6/6] tests/dpdk_gso_lib: modify dpdk code by dpdk change Wei Ling
@ 2022-06-24  6:48 ` He, Xingguang
  2022-06-24  6:49 ` Huang, ChenyuX
  2022-06-29  6:30 ` lijuan.tu
  2 siblings, 0 replies; 4+ messages in thread
From: He, Xingguang @ 2022-06-24  6:48 UTC (permalink / raw)
  To: Ling, WeiX, dts; +Cc: Ling, WeiX

> -----Original Message-----
> From: Wei Ling <weix.ling@intel.com>
> Sent: Friday, June 24, 2022 1:32 PM
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts][PATCH V1 6/6] tests/dpdk_gso_lib: modify dpdk code by dpdk
> change
> 
> According to the dpdk commit 1945c64674(app/testpmd: perform SW IP
> checksum for GRO/GSO packets) and commit 8ba1723783(net/vhost:
> perform SW checksum in Tx path), no need to modify DPDK code to test.
> 
> Signed-off-by: Wei Ling <weix.ling@intel.com>
> ---
Acked-by: Xingguang He<xingguang.he@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [dts][PATCH V1 6/6] tests/dpdk_gso_lib: modify dpdk code by dpdk change
  2022-06-24  5:32 [dts][PATCH V1 6/6] tests/dpdk_gso_lib: modify dpdk code by dpdk change Wei Ling
  2022-06-24  6:48 ` He, Xingguang
@ 2022-06-24  6:49 ` Huang, ChenyuX
  2022-06-29  6:30 ` lijuan.tu
  2 siblings, 0 replies; 4+ messages in thread
From: Huang, ChenyuX @ 2022-06-24  6:49 UTC (permalink / raw)
  To: Ling, WeiX, dts; +Cc: Ling, WeiX

> -----Original Message-----
> From: Wei Ling <weix.ling@intel.com>
> Sent: Friday, June 24, 2022 1:32 PM
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts][PATCH V1 6/6] tests/dpdk_gso_lib: modify dpdk code by dpdk
> change
> 
> According to the dpdk commit 1945c64674(app/testpmd: perform SW IP
> checksum for GRO/GSO packets) and commit 8ba1723783(net/vhost:
> perform SW checksum in Tx path), no need to modify DPDK code to test.
> 
> Signed-off-by: Wei Ling <weix.ling@intel.com>
> ---
Tested-by: Chenyu Huang <chenyux.huang@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts][PATCH V1 6/6] tests/dpdk_gso_lib: modify dpdk code by dpdk change
  2022-06-24  5:32 [dts][PATCH V1 6/6] tests/dpdk_gso_lib: modify dpdk code by dpdk change Wei Ling
  2022-06-24  6:48 ` He, Xingguang
  2022-06-24  6:49 ` Huang, ChenyuX
@ 2022-06-29  6:30 ` lijuan.tu
  2 siblings, 0 replies; 4+ messages in thread
From: lijuan.tu @ 2022-06-29  6:30 UTC (permalink / raw)
  To: dts, Wei Ling; +Cc: Wei Ling

On Fri, 24 Jun 2022 01:32:14 -0400, Wei Ling <weix.ling@intel.com> wrote:
> According to the dpdk commit 1945c64674(app/testpmd: perform SW IP
> checksum for GRO/GSO packets) and commit 8ba1723783(net/vhost:
> perform SW checksum in Tx path), no need to modify DPDK code to test.
> 
> Signed-off-by: Wei Ling <weix.ling@intel.com>


Series applied, thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-06-29  6:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-24  5:32 [dts][PATCH V1 6/6] tests/dpdk_gso_lib: modify dpdk code by dpdk change Wei Ling
2022-06-24  6:48 ` He, Xingguang
2022-06-24  6:49 ` Huang, ChenyuX
2022-06-29  6:30 ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).