test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] tests/TestSuite_link_flowctrl:add set_up
@ 2020-09-29  8:27 Chen Linglix
  2020-09-29  8:47 ` Chen, LingliX
  2020-10-13  2:15 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Chen Linglix @ 2020-09-29  8:27 UTC (permalink / raw)
  To: dts; +Cc: Chen Linglix

add set_up,tear_down:Avoid the influence between cases

Signed-off-by: Chen Linglix <linglix.chen@intel.com>
---
 tests/TestSuite_link_flowctrl.py | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_link_flowctrl.py b/tests/TestSuite_link_flowctrl.py
index 9e608bab..326f8b98 100644
--- a/tests/TestSuite_link_flowctrl.py
+++ b/tests/TestSuite_link_flowctrl.py
@@ -76,8 +76,6 @@ class TestLinkFlowctrl(TestCase):
 
         self.portMask = utils.create_mask([self.rx_port, self.tx_port])
 
-        self.pmdout = PmdOutput(self.dut)
-        self.pmdout.start_testpmd("all", "--portmask=%s" % self.portMask)
         # get dts output path
         if self.logger.log_path.startswith(os.sep):
             self.output_path = self.logger.log_path
@@ -88,6 +86,10 @@ class TestLinkFlowctrl(TestCase):
         # create an instance to set stream field setting
         self.pktgen_helper = PacketGeneratorHelper()
 
+    def set_up(self):
+        self.pmdout = PmdOutput(self.dut)
+        self.pmdout.start_testpmd("all", "--portmask=%s" % self.portMask)
+
     def get_tgen_input(self):
         """
         create streams for ports.
@@ -563,9 +565,15 @@ class TestLinkFlowctrl(TestCase):
                         "Link flow control fail, the loss percent is less than 50%")
         self.dut.send_expect("stop", "testpmd> ")
 
-    def tear_down_all(self):
+    def tear_down(self):
         """
         Run after each test case.
         """
-        self.dut.kill_all()
         self.dut.send_expect("quit", "# ")
+        self.dut.kill_all()
+    
+    def tear_down_all(self):
+        """
+        Run after each test suite.
+        """
+        pass
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_link_flowctrl:add set_up
  2020-09-29  8:27 [dts] [PATCH V1] tests/TestSuite_link_flowctrl:add set_up Chen Linglix
@ 2020-09-29  8:47 ` Chen, LingliX
  2020-10-13  2:15 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Chen, LingliX @ 2020-09-29  8:47 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

Tested-by:  Chen, LingliX <linglix.chen@intel.com>

Regards,
Chen, LingliX

> -----Original Message-----
> From: Chen, LingliX
> Sent: Tuesday, September 29, 2020 4:28 PM
> To: dts@dpdk.org
> Cc: Chen, LingliX <linglix.chen@intel.com>
> Subject: [dts][PATCH V1] tests/TestSuite_link_flowctrl:add set_up

[-- Attachment #2: TestLinkFlowctrl.log --]
[-- Type: application/octet-stream, Size: 146936 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_link_flowctrl:add set_up
  2020-09-29  8:27 [dts] [PATCH V1] tests/TestSuite_link_flowctrl:add set_up Chen Linglix
  2020-09-29  8:47 ` Chen, LingliX
@ 2020-10-13  2:15 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-10-13  2:15 UTC (permalink / raw)
  To: Chen, LingliX, dts; +Cc: Chen, LingliX

> add set_up,tear_down:Avoid the influence between cases
> 
> Signed-off-by: Chen Linglix <linglix.chen@intel.com>

Applied

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-29  8:27 [dts] [PATCH V1] tests/TestSuite_link_flowctrl:add set_up Chen Linglix
2020-09-29  8:47 ` Chen, LingliX
2020-10-13  2:15 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox