test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: fix lost case result when teardown fail
@ 2020-03-12 11:15 Xiao Qimai
  2020-03-12 11:15 ` [dts] [PATCH V1]tests/TestSuite_vhost_multi_queue_qemu: fix teardown fail caused lost case result Xiao Qimai
  2020-03-17  5:17 ` [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: fix lost case result when teardown fail Tu, Lijuan
  0 siblings, 2 replies; 5+ messages in thread
From: Xiao Qimai @ 2020-03-12 11:15 UTC (permalink / raw)
  To: dts; +Cc: Xiao Qimai

*. fix lost case result when teardown fail

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_vhost_pmd_xstats.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_vhost_pmd_xstats.py b/tests/TestSuite_vhost_pmd_xstats.py
index 0ebbe1c..e9f79ed 100755
--- a/tests/TestSuite_vhost_pmd_xstats.py
+++ b/tests/TestSuite_vhost_pmd_xstats.py
@@ -229,7 +229,8 @@ class TestVhostPmdXstats(TestCase):
         """
         Run after each test case.
         """
-        self.vm._stop_vm()
+        if hasattr(self, "vm"):
+            self.vm._stop_vm()
         self.dut.kill_all()
         time.sleep(2)
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V1]tests/TestSuite_vhost_multi_queue_qemu: fix teardown fail caused lost case result
  2020-03-12 11:15 [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: fix lost case result when teardown fail Xiao Qimai
@ 2020-03-12 11:15 ` Xiao Qimai
  2020-03-16  5:31   ` Tu, Lijuan
  2020-03-17  5:17 ` [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: fix lost case result when teardown fail Tu, Lijuan
  1 sibling, 1 reply; 5+ messages in thread
From: Xiao Qimai @ 2020-03-12 11:15 UTC (permalink / raw)
  To: dts; +Cc: Xiao Qimai

*. fix lost case result

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_vhost_multi_queue_qemu.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_vhost_multi_queue_qemu.py b/tests/TestSuite_vhost_multi_queue_qemu.py
index c98b4ea..7dcb18c 100644
--- a/tests/TestSuite_vhost_multi_queue_qemu.py
+++ b/tests/TestSuite_vhost_multi_queue_qemu.py
@@ -326,7 +326,8 @@ class TestVhostMultiQueueQemu(TestCase):
         Run after each test case.
         Clear vhost-switch and qemu to avoid blocking the following TCs
         """
-        self.vm.stop()
+        is hasattr(self, "vm"):
+            self.vm.stop()
         self.dut.kill_all()
         time.sleep(2)
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1]tests/TestSuite_vhost_multi_queue_qemu: fix teardown fail caused lost case result
  2020-03-12 11:15 ` [dts] [PATCH V1]tests/TestSuite_vhost_multi_queue_qemu: fix teardown fail caused lost case result Xiao Qimai
@ 2020-03-16  5:31   ` Tu, Lijuan
  2020-03-17  6:49     ` Xiao, QimaiX
  0 siblings, 1 reply; 5+ messages in thread
From: Tu, Lijuan @ 2020-03-16  5:31 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX



> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Thursday, March 12, 2020 7:16 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]tests/TestSuite_vhost_multi_queue_qemu: fix
> teardown fail caused lost case result
> 
> *. fix lost case result
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_vhost_multi_queue_qemu.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vhost_multi_queue_qemu.py
> b/tests/TestSuite_vhost_multi_queue_qemu.py
> index c98b4ea..7dcb18c 100644
> --- a/tests/TestSuite_vhost_multi_queue_qemu.py
> +++ b/tests/TestSuite_vhost_multi_queue_qemu.py
> @@ -326,7 +326,8 @@ class TestVhostMultiQueueQemu(TestCase):
>          Run after each test case.
>          Clear vhost-switch and qemu to avoid blocking the following TCs
>          """
> -        self.vm.stop()
> +        is hasattr(self, "vm"):
[Lijuan] is should be if
> +            self.vm.stop()
>          self.dut.kill_all()
>          time.sleep(2)
> 
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: fix lost case result when teardown fail
  2020-03-12 11:15 [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: fix lost case result when teardown fail Xiao Qimai
  2020-03-12 11:15 ` [dts] [PATCH V1]tests/TestSuite_vhost_multi_queue_qemu: fix teardown fail caused lost case result Xiao Qimai
@ 2020-03-17  5:17 ` Tu, Lijuan
  1 sibling, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2020-03-17  5:17 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Thursday, March 12, 2020 7:16 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: fix lost case
> result when teardown fail
> 
> *. fix lost case result when teardown fail
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_vhost_pmd_xstats.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vhost_pmd_xstats.py
> b/tests/TestSuite_vhost_pmd_xstats.py
> index 0ebbe1c..e9f79ed 100755
> --- a/tests/TestSuite_vhost_pmd_xstats.py
> +++ b/tests/TestSuite_vhost_pmd_xstats.py
> @@ -229,7 +229,8 @@ class TestVhostPmdXstats(TestCase):
>          """
>          Run after each test case.
>          """
> -        self.vm._stop_vm()
> +        if hasattr(self, "vm"):
> +            self.vm._stop_vm()
>          self.dut.kill_all()
>          time.sleep(2)
> 
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1]tests/TestSuite_vhost_multi_queue_qemu: fix teardown fail caused lost case result
  2020-03-16  5:31   ` Tu, Lijuan
@ 2020-03-17  6:49     ` Xiao, QimaiX
  0 siblings, 0 replies; 5+ messages in thread
From: Xiao, QimaiX @ 2020-03-17  6:49 UTC (permalink / raw)
  To: Tu, Lijuan, dts

Thanks Lijuan, I'll submit patch version2

Regards,
Xiao Qimai

> -----Original Message-----
> From: Tu, Lijuan
> Sent: Monday, March 16, 2020 1:32 PM
> To: Xiao, QimaiX <qimaix.xiao@intel.com>; dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: RE: [dts] [PATCH V1]tests/TestSuite_vhost_multi_queue_qemu: fix
> teardown fail caused lost case result
> 
> 
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> > Sent: Thursday, March 12, 2020 7:16 PM
> > To: dts@dpdk.org
> > Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> > Subject: [dts] [PATCH V1]tests/TestSuite_vhost_multi_queue_qemu: fix
> > teardown fail caused lost case result
> >
> > *. fix lost case result
> >
> > Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> > ---
> >  tests/TestSuite_vhost_multi_queue_qemu.py | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/TestSuite_vhost_multi_queue_qemu.py
> > b/tests/TestSuite_vhost_multi_queue_qemu.py
> > index c98b4ea..7dcb18c 100644
> > --- a/tests/TestSuite_vhost_multi_queue_qemu.py
> > +++ b/tests/TestSuite_vhost_multi_queue_qemu.py
> > @@ -326,7 +326,8 @@ class TestVhostMultiQueueQemu(TestCase):
> >          Run after each test case.
> >          Clear vhost-switch and qemu to avoid blocking the following TCs
> >          """
> > -        self.vm.stop()
> > +        is hasattr(self, "vm"):
> [Lijuan] is should be if
> > +            self.vm.stop()
> >          self.dut.kill_all()
> >          time.sleep(2)
> >
> > --
> > 1.8.3.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-12 11:15 [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: fix lost case result when teardown fail Xiao Qimai
2020-03-12 11:15 ` [dts] [PATCH V1]tests/TestSuite_vhost_multi_queue_qemu: fix teardown fail caused lost case result Xiao Qimai
2020-03-16  5:31   ` Tu, Lijuan
2020-03-17  6:49     ` Xiao, QimaiX
2020-03-17  5:17 ` [dts] [PATCH V1]tests/TestSuite_vhost_pmd_xstats: fix lost case result when teardown fail Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox