test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/cvl_fdir: add mark id
@ 2021-11-12  8:03 Jiale Song
  2021-11-23 14:36 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Jiale Song @ 2021-11-12  8:03 UTC (permalink / raw)
  To: dts; +Cc: Jiale Song

after the packet comes in, it hits the switch rule first and then the fdir rule. the final action
is the superposition of the two. the priority of switch is higher than fdir, so it goes to the 
switch queue, but it still contains the fdir mark action

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 test_plans/cvl_fdir_test_plan.rst | 4 ++--
 tests/TestSuite_cvl_fdir.py       | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/test_plans/cvl_fdir_test_plan.rst b/test_plans/cvl_fdir_test_plan.rst
index 4c4526d8..ed1214f9 100644
--- a/test_plans/cvl_fdir_test_plan.rst
+++ b/test_plans/cvl_fdir_test_plan.rst
@@ -3589,7 +3589,7 @@ set "--log-level=ice,7", then check::
     sendp([Ether(dst="00:11:22:33:44:55")/IP(src="192.168.0.20",dst="192.168.0.21") /UDP(sport=22, dport=23)/ Raw('x' * 80)],iface="enp175s0f0", count=10)
 
    the two packets are both redirected to queue 1 with mark ID 1.
-   then create MAC_IPV4_UDP flow, it is set to switch filter::
+   then create MAC_IPV4_UDP flow, it is set to switch filter with mark ID 1::
 
     flow create 0 ingress pattern eth / ipv4 dst is 192.168.0.21 / udp src is 22 dst is 23 / end actions queue index 2 / end
 
@@ -3610,7 +3610,7 @@ set "--log-level=ice,7", then check::
 
     flow create 0 ingress pattern eth / ipv4 dst is 192.168.0.21 / end actions queue index 1 / end
 
-   send same packet, it is redirected to queue 1, because the packet match switch filter first.
+   send same packet, it is redirected to queue 1 with mark ID 1, because the packet match switch filter first.
 
 
 Test case: count/query
diff --git a/tests/TestSuite_cvl_fdir.py b/tests/TestSuite_cvl_fdir.py
index d4cb90ce..529be0e8 100644
--- a/tests/TestSuite_cvl_fdir.py
+++ b/tests/TestSuite_cvl_fdir.py
@@ -3007,7 +3007,7 @@ class TestCVLFdir(TestCase):
         out = self.send_pkts_getouput(pkts=pkts[0])
         rfc.check_mark(out, pkt_num=1, check_param={"port_id": 0, "queue": 1,"mark_id":1}, stats=True)
         out = self.send_pkts_getouput(pkts=pkts[1])
-        rfc.check_mark(out, pkt_num=1, check_param={"port_id": 0, "queue": 2}, stats=True)
+        rfc.check_mark(out, pkt_num=1, check_param={"port_id": 0, "queue": 2,"mark_id":1}, stats=True)
 
         rule3 = "flow create 0 ingress pattern eth / ipv4 dst is 192.168.0.21 / udp src is 22 dst is 23 / end actions queue index 2 / mark id 1 / end"
         rule4 = "flow create 0 ingress pattern eth / ipv4 dst is 192.168.0.21 / end actions queue index 1 / end"
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [dts] [PATCH V1] tests/cvl_fdir: add mark id
  2021-11-12  8:03 [dts] [PATCH V1] tests/cvl_fdir: add mark id Jiale Song
@ 2021-11-23 14:36 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2021-11-23 14:36 UTC (permalink / raw)
  To: Jiale, SongX, dts; +Cc: Jiale, SongX

> -----Original Message-----
> From: Jiale Song <songx.jiale@intel.com>
> Sent: 2021年11月12日 16:03
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/cvl_fdir: add mark id
> 
> after the packet comes in, it hits the switch rule first and then the fdir rule. the
> final action is the superposition of the two. the priority of switch is higher than
> fdir, so it goes to the switch queue, but it still contains the fdir mark action
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-23 14:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-12  8:03 [dts] [PATCH V1] tests/cvl_fdir: add mark id Jiale Song
2021-11-23 14:36 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git