From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F5D3A0564; Fri, 28 Feb 2020 04:20:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 241E137AF; Fri, 28 Feb 2020 04:20:24 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 656342C4F for ; Fri, 28 Feb 2020 04:20:22 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2020 19:20:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,493,1574150400"; d="scan'208";a="350826947" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 27 Feb 2020 19:20:21 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Feb 2020 19:20:20 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 28 Feb 2020 11:20:18 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Fri, 28 Feb 2020 11:20:18 +0800 From: "Xiao, QimaiX" To: "Wang, Yinan" , "Tu, Lijuan" , "Zhao, HaiyangX" , "dts@dpdk.org" CC: "Zhao, HaiyangX" Thread-Topic: [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env Thread-Index: AQHV7eO6RTmeZ1dZAUS+ktbFUuImq6gv7vQw Date: Fri, 28 Feb 2020 03:20:18 +0000 Message-ID: <6322b05aae134b4da83f721a5beea7de@intel.com> References: <1582619670-406390-1-git-send-email-haiyangx.zhao@intel.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BBCDFD2@SHSMSX101.ccr.corp.intel.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BBE3B8A@SHSMSX101.ccr.corp.intel.com> <38d7782f5b5d44cca27d12c7b4831cb3@intel.com> In-Reply-To: <38d7782f5b5d44cca27d12c7b4831cb3@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi, Lijuan This patch only remove unnecessary single-file-segments parameter for vhost= side in 2M env. Regards, Xiao Qimai > -----Original Message----- > From: Wang, Yinan > Sent: Friday, February 28, 2020 11:04 AM > To: Tu, Lijuan ; Xiao, QimaiX ; > Zhao, HaiyangX ; dts@dpdk.org > Cc: Zhao, HaiyangX > Subject: RE: [dts] [PATCH > V1]tests/TestSuite_virtio_user_for_container_networking: remove > redundant parameter single-file-segments if not 2M env >=20 > Hi Lijuan, >=20 >=20 > Since 2M page smaller than 1G, so need more hug pages ,single-file- > segments can help to create fewer files in hugetlbfs. > It only used in virtio-user side is ok. >=20 > BR, > Yinan >=20 > > -----Original Message----- > > From: dts On Behalf Of Tu, Lijuan > > Sent: 2020=1B$BG/=1B(B2=1B$B7n=1B(B28=1B$BF|=1B(B 10:51 > > To: Xiao, QimaiX ; Zhao, HaiyangX > > ; dts@dpdk.org > > Cc: Zhao, HaiyangX > > Subject: Re: [dts] [PATCH > > V1]tests/TestSuite_virtio_user_for_container_networking: remove > > redundant parameter single-file-segments if not 2M env > > > > As you said, it was required on 2M env, so it's not reasonable to > > remove it without any judgement. > > > > > -----Original Message----- > > > From: Xiao, QimaiX > > > Sent: Friday, February 28, 2020 10:37 AM > > > To: Tu, Lijuan ; Zhao, HaiyangX > > > ; dts@dpdk.org > > > Cc: Zhao, HaiyangX > > > Subject: RE: [dts] [PATCH > > > V1]tests/TestSuite_virtio_user_for_container_networking: remove > > > redundant parameter single-file-segments if not 2M env > > > > > > Hi, Lijuan > > > > > > I consulted lihong that single-file-segments parameter only required > > > on virtio side in 2M env, vhost side doesn't need, so it's ok to remo= ve it. > > > > > > Regards, > > > Xiao Qimai > > > > > > > > > > -----Original Message----- > > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan > > > > Sent: Tuesday, February 25, 2020 5:01 PM > > > > To: Zhao, HaiyangX ; dts@dpdk.org > > > > Cc: Zhao, HaiyangX > > > > Subject: Re: [dts] [PATCH > > > > V1]tests/TestSuite_virtio_user_for_container_networking: remove > > > > redundant parameter single-file-segments if not 2M env > > > > > > > > Remove single-file-segments, so what will happen, if 2M env ? > > > > > > > > > -----Original Message----- > > > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang > > > > > Zhao > > > > > Sent: Tuesday, February 25, 2020 4:35 PM > > > > > To: dts@dpdk.org > > > > > Cc: Zhao, HaiyangX > > > > > Subject: [dts] [PATCH > > > > > V1]tests/TestSuite_virtio_user_for_container_networking: remove > > > > > redundant parameter single-file-segments if not 2M env > > > > > > > > > > remove redundant parameter > > > > > > > > > > Signed-off-by: Haiyang Zhao > > > > > --- > > > > > tests/TestSuite_virtio_user_for_container_networking.py | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git > > > > > a/tests/TestSuite_virtio_user_for_container_networking.py > > > > > b/tests/TestSuite_virtio_user_for_container_networking.py > > > > > index ba303b7..1f9a666 100644 > > > > > --- a/tests/TestSuite_virtio_user_for_container_networking.py > > > > > +++ b/tests/TestSuite_virtio_user_for_container_networking.py > > > > > @@ -164,7 +164,7 @@ class TestVirtioUserForContainer(TestCase): > > > > > command_line_user =3D 'docker run -i -t --privileged > > > > > -v > > > > > %s/vhost- net:/tmp/vhost-net ' + \ > > > > > '-v /mnt/huge:/dev/hugepages ' + \ > > > > > '-v %s:%s %s .%s/%s/app/testpmd > > -c %s -n %d ' + \ > > > > > - '-m 1024 --no-pci --file-prefix=3Dco= ntainer > > --single-file- > > > > > segments ' + \ > > > > > + '-m 1024 --no-pci > > > > > + --file-prefix=3Dcontainer ' + \ > > > > > '-- > > > > > vdev=3Dvirtio_user0,mac=3D00:11:22:33:44:10,path=3D/tmp/vhost- > > > > net,queues=3D%d ' > > > > > + \ > > > > > '-- -i --rxq=3D%d --txq=3D%d > > --nb-cores=3D%d' > > > > > command_line_user =3D command_line_user % > > > > > (self.container_base_dir, > > > > > -- > > > > > 1.8.3.1