From: Lijuan Tu <lijuan.tu@intel.com>
To: "zhao,meijuan" <meijuanx.zhao@intel.com>, dts@dpdk.org
Subject: Re: [dts] [PATCH V1] tests/vf mackfilter: fix syntax error
Date: Mon, 3 Dec 2018 20:00:06 +0800 [thread overview]
Message-ID: <638615d0-a381-fc6f-2481-4bb6512c7e97@intel.com> (raw)
In-Reply-To: <1543553692-11863-1-git-send-email-meijuanx.zhao@intel.com>
Applied, thanks, appreciate if you could be more careful.
On 2018年11月30日 12:54, zhao,meijuan wrote:
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
> tests/TestSuite_vf_macfilter.py | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/TestSuite_vf_macfilter.py b/tests/TestSuite_vf_macfilter.py
> index 9e6db42..12a08e8 100644
> --- a/tests/TestSuite_vf_macfilter.py
> +++ b/tests/TestSuite_vf_macfilter.py
> @@ -37,7 +37,7 @@ class TestVfMacFilter(TestCase):
>
> self.setup_2pf_2vf_1vm_env_flag = 0
>
> - def setup_2pf_2vf_1vm_env(self, driver='default',set_mac):
> + def setup_2pf_2vf_1vm_env(self,set_mac,driver='default'):
>
> self.used_dut_port_0 = self.dut_ports[0]
> self.dut.generate_sriov_vfs_by_port(self.used_dut_port_0, 1, driver=driver)
> @@ -128,7 +128,7 @@ class TestVfMacFilter(TestCase):
> if the MAC filter works. Also send the packets with wrong MAC
> address to VF, check if the VF will not RX the packets.
> """
> - self.setup_2pf_2vf_1vm_env(driver='',True)
> + self.setup_2pf_2vf_1vm_env(True,driver='')
> self.result_verify_iplink(True)
>
> def result_verify_iplink(self,set_mac):
> @@ -177,7 +177,7 @@ class TestVfMacFilter(TestCase):
> What's more, send packets with a wrong MAC address to the VF will
> not received by the VF.
> """
> - self.setup_2pf_2vf_1vm_env(driver='',False)
> + self.setup_2pf_2vf_1vm_env(False,driver='')
> self.send_packet_and_verify()
>
> def test_dpdk_2pf_2vf_1vm_mac_add_filter(self):
> @@ -191,7 +191,7 @@ class TestVfMacFilter(TestCase):
> What's more, send packets with a wrong MAC address to the VF will
> not received by the VF.
> """
> - self.setup_2pf_2vf_1vm_env(driver='igb_uio',False)
> + self.setup_2pf_2vf_1vm_env(False,driver='igb_uio')
> self.send_packet_and_verify()
>
> def test_dpdk_2pf_2vf_1vm_iplink_macfilter(self):
> @@ -203,7 +203,7 @@ class TestVfMacFilter(TestCase):
> not RX the packets works. Also send the packets with wrong MAC
> address to VF, check if the VF will not RX the packets.
> """
> - self.setup_2pf_2vf_1vm_env(driver='igb_uio',False)
> + self.setup_2pf_2vf_1vm_env(False,driver='igb_uio')
> self.result_verify_iplink(False)
>
> def send_packet_and_verify(self):
prev parent reply other threads:[~2018-12-03 3:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 4:54 zhao,meijuan
2018-12-03 12:00 ` Lijuan Tu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=638615d0-a381-fc6f-2481-4bb6512c7e97@intel.com \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=meijuanx.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).