From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 6F3811B207 for ; Mon, 3 Dec 2018 04:32:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2018 19:32:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,308,1539673200"; d="scan'208";a="126368334" Received: from dts-maintain.sh.intel.com (HELO [10.67.119.110]) ([10.67.119.110]) by fmsmga001.fm.intel.com with ESMTP; 02 Dec 2018 19:32:18 -0800 To: "zhao,meijuan" , dts@dpdk.org References: <1543553692-11863-1-git-send-email-meijuanx.zhao@intel.com> From: Lijuan Tu Message-ID: <638615d0-a381-fc6f-2481-4bb6512c7e97@intel.com> Date: Mon, 3 Dec 2018 20:00:06 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1543553692-11863-1-git-send-email-meijuanx.zhao@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dts] [PATCH V1] tests/vf mackfilter: fix syntax error X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Dec 2018 03:32:19 -0000 Applied, thanks, appreciate if you could be more careful. On 2018年11月30日 12:54, zhao,meijuan wrote: > Signed-off-by: zhao,meijuan > --- > tests/TestSuite_vf_macfilter.py | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tests/TestSuite_vf_macfilter.py b/tests/TestSuite_vf_macfilter.py > index 9e6db42..12a08e8 100644 > --- a/tests/TestSuite_vf_macfilter.py > +++ b/tests/TestSuite_vf_macfilter.py > @@ -37,7 +37,7 @@ class TestVfMacFilter(TestCase): > > self.setup_2pf_2vf_1vm_env_flag = 0 > > - def setup_2pf_2vf_1vm_env(self, driver='default',set_mac): > + def setup_2pf_2vf_1vm_env(self,set_mac,driver='default'): > > self.used_dut_port_0 = self.dut_ports[0] > self.dut.generate_sriov_vfs_by_port(self.used_dut_port_0, 1, driver=driver) > @@ -128,7 +128,7 @@ class TestVfMacFilter(TestCase): > if the MAC filter works. Also send the packets with wrong MAC > address to VF, check if the VF will not RX the packets. > """ > - self.setup_2pf_2vf_1vm_env(driver='',True) > + self.setup_2pf_2vf_1vm_env(True,driver='') > self.result_verify_iplink(True) > > def result_verify_iplink(self,set_mac): > @@ -177,7 +177,7 @@ class TestVfMacFilter(TestCase): > What's more, send packets with a wrong MAC address to the VF will > not received by the VF. > """ > - self.setup_2pf_2vf_1vm_env(driver='',False) > + self.setup_2pf_2vf_1vm_env(False,driver='') > self.send_packet_and_verify() > > def test_dpdk_2pf_2vf_1vm_mac_add_filter(self): > @@ -191,7 +191,7 @@ class TestVfMacFilter(TestCase): > What's more, send packets with a wrong MAC address to the VF will > not received by the VF. > """ > - self.setup_2pf_2vf_1vm_env(driver='igb_uio',False) > + self.setup_2pf_2vf_1vm_env(False,driver='igb_uio') > self.send_packet_and_verify() > > def test_dpdk_2pf_2vf_1vm_iplink_macfilter(self): > @@ -203,7 +203,7 @@ class TestVfMacFilter(TestCase): > not RX the packets works. Also send the packets with wrong MAC > address to VF, check if the VF will not RX the packets. > """ > - self.setup_2pf_2vf_1vm_env(driver='igb_uio',False) > + self.setup_2pf_2vf_1vm_env(False,driver='igb_uio') > self.result_verify_iplink(False) > > def send_packet_and_verify(self):