test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1 1/2] tests/kernelpf_iavf: modify script to adapt the intree kernel driver
@ 2023-01-30 11:12 Song Jiale
  2023-01-30 11:12 ` [dts] [PATCH V1 2/2] test_plans/kernelpf_iavf: adapt to " Song Jiale
  0 siblings, 1 reply; 3+ messages in thread
From: Song Jiale @ 2023-01-30 11:12 UTC (permalink / raw)
  To: dts; +Cc: Song Jiale

modify the script to adapt to the situation that the kernel driver cannot set
"vf-vlan-running".

Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 5e955feb..86c12d85 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -869,7 +869,10 @@ class TestKernelpfIavf(TestCase):
         self.check_vlan_offload(vlan_type="filter", stats="on")
         out = self.send_pkts_getouput(self.tester_intf, pkt_list1)
         receive_pkt = re.findall("dst=%s" % self.vf_mac, out)
-        self.verify(len(receive_pkt) == 0, "Failed error received vlan packet!")
+        if self.default_stats:
+            self.verify(len(receive_pkt) == 0, "Failed error received vlan packet!")
+        else:
+            self.verify(len(receive_pkt) == 2, "Failed error received vlan packet!")
 
         self.vm_testpmd.execute_cmd("rx_vlan add 1 0")
         self.start_tcpdump(self.tester_intf)
@@ -887,7 +890,10 @@ class TestKernelpfIavf(TestCase):
         self.vm_testpmd.execute_cmd("rx_vlan rm 1 0")
         out = self.send_pkts_getouput(self.tester_intf, pkt_list1)
         receive_pkt = re.findall("dst=%s" % self.vf_mac, out)
-        self.verify(len(receive_pkt) == 0, "Failed error received vlan packet!")
+        if self.default_stats:
+            self.verify(len(receive_pkt) == 0, "Failed error received vlan packet!")
+        else:
+            self.verify(len(receive_pkt) == 2, "Failed error received vlan packet!")
 
     @check_supported_nic(ice_nic)
     def test_iavf_dual_vlan_strip(self):
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1 2/2] test_plans/kernelpf_iavf: adapt to the intree kernel driver
  2023-01-30 11:12 [dts] [PATCH V1 1/2] tests/kernelpf_iavf: modify script to adapt the intree kernel driver Song Jiale
@ 2023-01-30 11:12 ` Song Jiale
  2023-03-07  3:49   ` lijuan.tu
  0 siblings, 1 reply; 3+ messages in thread
From: Song Jiale @ 2023-01-30 11:12 UTC (permalink / raw)
  To: dts; +Cc: Song Jiale

the intree kernel driver cannot set "vf-vlan-running", modify the
testplan to adapt to this difference.

Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 test_plans/kernelpf_iavf_test_plan.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test_plans/kernelpf_iavf_test_plan.rst b/test_plans/kernelpf_iavf_test_plan.rst
index 5b91d38b..b708c75b 100644
--- a/test_plans/kernelpf_iavf_test_plan.rst
+++ b/test_plans/kernelpf_iavf_test_plan.rst
@@ -394,7 +394,7 @@ Test case: IAVF DUAL VLAN filtering
     sendp([Ether(dst="00:11:22:33:44:11",type=0x8100)/Dot1Q(vlan=1,type=0x8100)/Dot1Q(vlan=2,type=0x0800)/IP(src="196.222.232.221")/("X"*480)], iface="ens786f0")
     sendp([Ether(dst="00:11:22:33:44:11",type=0x8100)/Dot1Q(vlan=1,type=0x0800)/IP(src="196.222.232.221")/("X"*480)], iface="ens786f0")
 
-4. check the pkts can't be received in VF.
+4. check the pkts can't be received in VF, but if the kernel cannot set ``vf-vlan-pruning``, check can receive 2 pkts in VF.
 
 5. add rx_vlan in VF::
 
@@ -428,7 +428,7 @@ Test case: IAVF DUAL VLAN filtering
 
     testpmd> rx_vlan rm 1 0
 
-10. repeat step 3, check the pkts can not be received by VF.
+10. repeat step 3, check the pkts can not be received by VF, but if the kernel cannot set ``vf-vlan-pruning``, check can receive 2 pkts in VF.
 
 
 Test case: IAVF DUAL VLAN header stripping
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1 2/2] test_plans/kernelpf_iavf: adapt to the intree kernel driver
  2023-01-30 11:12 ` [dts] [PATCH V1 2/2] test_plans/kernelpf_iavf: adapt to " Song Jiale
@ 2023-03-07  3:49   ` lijuan.tu
  0 siblings, 0 replies; 3+ messages in thread
From: lijuan.tu @ 2023-03-07  3:49 UTC (permalink / raw)
  To: dts, Song Jiale; +Cc: Song Jiale

On Mon, 30 Jan 2023 11:12:26 +0000, Song Jiale <songx.jiale@intel.com> wrote:
> the intree kernel driver cannot set "vf-vlan-running", modify the
> testplan to adapt to this difference.
> 
> Signed-off-by: Song Jiale <songx.jiale@intel.com>


Series applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-07  3:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-30 11:12 [dts] [PATCH V1 1/2] tests/kernelpf_iavf: modify script to adapt the intree kernel driver Song Jiale
2023-01-30 11:12 ` [dts] [PATCH V1 2/2] test_plans/kernelpf_iavf: adapt to " Song Jiale
2023-03-07  3:49   ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).