test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Xiao, QimaiX" <qimaix.xiao@intel.com>
To: "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1]vm2vm_virtio_pmd: fix pdump eal parameter
Date: Tue, 7 Apr 2020 02:06:37 +0000	[thread overview]
Message-ID: <6654c01b9afc4e0fb206a69deb523b4d@intel.com> (raw)
In-Reply-To: <1586224824-295603-1-git-send-email-qimaix.xiao@intel.com>

Tested-by: Xiao, QimaiX <qimaix.xiao@intel.com>

Regards,
Xiao Qimai

> -----Original Message-----
> From: Xiao, QimaiX
> Sent: Tuesday, April 7, 2020 10:00 AM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts][PATCH V1]vm2vm_virtio_pmd: fix pdump eal parameter
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_vm2vm_virtio_pmd.py | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_vm2vm_virtio_pmd.py
> b/tests/TestSuite_vm2vm_virtio_pmd.py
> index 5bc0d01..62929e0 100644
> --- a/tests/TestSuite_vm2vm_virtio_pmd.py
> +++ b/tests/TestSuite_vm2vm_virtio_pmd.py
> @@ -167,10 +167,16 @@ class TestVM2VMVirtioPMD(TestCase):
>          bootup pdump in VM
>          """
>          self.pdump_session = client_dut.new_session(suite="pdump")
> -        command_line = self.target + "/app/dpdk-pdump " + \
> +        if hasattr(client_dut, "vm_name"):
> +            command_line = self.target + "/app/dpdk-pdump " + \
>                      "-v --file-prefix=virtio -- " + \
>                      "--pdump  '%s,queue=*,rx-dev=%s,mbuf-size=8000'"
> -        self.pdump_session.send_expect(command_line % (dump_port,
> self.dump_pcap), 'Port')
> +            self.pdump_session.send_expect(command_line % (dump_port,
> self.dump_pcap), 'Port')
> +        else:
> +            command_line = self.target + "/app/dpdk-pdump " + \
> +                    "-v --file-prefix=virtio_%s -- " + \
> +                    "--pdump  '%s,queue=*,rx-dev=%s,mbuf-size=8000'"
> +            self.pdump_session.send_expect(command_line %
> (self.dut.prefix_subfix, dump_port, self.dump_pcap), 'Port')
> 
>      def start_vms(self, mode=0, mergeable=True):
>          """
> --
> 1.8.3.1


  reply	other threads:[~2020-04-07  2:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07  2:00 Xiao Qimai
2020-04-07  2:06 ` Xiao, QimaiX [this message]
2020-04-17  9:04 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6654c01b9afc4e0fb206a69deb523b4d@intel.com \
    --to=qimaix.xiao@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).