test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2 2/2] test_plans/userspace_ethtool: add note to support ixgbe nic
  2023-01-10 15:19 ` [dts] [PATCH V2 2/2] test_plans/userspace_ethtool: add note " Song Jiale
@ 2023-01-10  8:01   ` lijuan.tu
  0 siblings, 0 replies; 3+ messages in thread
From: lijuan.tu @ 2023-01-10  8:01 UTC (permalink / raw)
  To: dts, Song Jiale; +Cc: Song Jiale

On Tue, 10 Jan 2023 15:19:55 +0000, Song Jiale <songx.jiale@intel.com> wrote:
> according to the solution provided by the EPG team, if you read eeprom
> on the ixgbe nic, use the "length" parameter to reduce the size to
> 0x4000.
> 
> Signed-off-by: Song Jiale <songx.jiale@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Series applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V2 1/2] tests/userspace_ethtool: modify dts script to support ixgbe nic
@ 2023-01-10 15:19 Song Jiale
  2023-01-10 15:19 ` [dts] [PATCH V2 2/2] test_plans/userspace_ethtool: add note " Song Jiale
  0 siblings, 1 reply; 3+ messages in thread
From: Song Jiale @ 2023-01-10 15:19 UTC (permalink / raw)
  To: dts; +Cc: Song Jiale

according to the solution provided by the EPG team, if you read eeprom
on the ixgbe nic, use the "length" parameter to reduce the size to
0x4000.

Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index d8db9073..b62e732f 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -406,6 +406,17 @@ class TestUserspaceEthtool(TestCase):
             self.dut.send_expect(
                 "ethtool --eeprom-dump %s raw on > %s" % (intf, ethtool_eeprom), "# "
             )
+            if self.kdriver == "ixgbe":
+                self.dut.send_expect(
+                    "ethtool --eeprom-dump %s length 0x4000 raw on > %s"
+                    % (intf, ethtool_eeprom),
+                    "# ",
+                )
+            else:
+                self.dut.send_expect(
+                    "ethtool --eeprom-dump %s raw on > %s" % (intf, ethtool_eeprom),
+                    "# ",
+                )
             # wait for file ready
             time.sleep(2)
             # dpdk userspcae tools dump eeprom file size different with kernel ethtool dump
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V2 2/2] test_plans/userspace_ethtool: add note to support ixgbe nic
  2023-01-10 15:19 [dts] [PATCH V2 1/2] tests/userspace_ethtool: modify dts script to support ixgbe nic Song Jiale
@ 2023-01-10 15:19 ` Song Jiale
  2023-01-10  8:01   ` lijuan.tu
  0 siblings, 1 reply; 3+ messages in thread
From: Song Jiale @ 2023-01-10 15:19 UTC (permalink / raw)
  To: dts; +Cc: Song Jiale

according to the solution provided by the EPG team, if you read eeprom
on the ixgbe nic, use the "length" parameter to reduce the size to
0x4000.

Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 test_plans/userspace_ethtool_test_plan.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/test_plans/userspace_ethtool_test_plan.rst b/test_plans/userspace_ethtool_test_plan.rst
index a0863e0a..24a1571a 100644
--- a/test_plans/userspace_ethtool_test_plan.rst
+++ b/test_plans/userspace_ethtool_test_plan.rst
@@ -76,6 +76,10 @@ Dump eeprom binary by linux's ethtool and dpdk's ethtool separately::
    ethtool --eeprom-dump INTF_0 raw on > ethtool_eeprom_0.bin
    ethtool --eeprom-dump INTF_1 raw on > ethtool_eeprom_1.bin
 
+.. note::
+   In case on ixgbe NIC to read the eeprom, please use 'length' parameter to reduce size to 0x4000.
+   For example: ethtool --eeprom-dump {INTF} length 0x4000.
+
 Retrieve eeprom on specified port using dpdk's ethtool and
 compare csum with the file dumped by ethtool::
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-10  8:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-10 15:19 [dts] [PATCH V2 1/2] tests/userspace_ethtool: modify dts script to support ixgbe nic Song Jiale
2023-01-10 15:19 ` [dts] [PATCH V2 2/2] test_plans/userspace_ethtool: add note " Song Jiale
2023-01-10  8:01   ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).