RE: [PATCH v1] framework/dut: fix pylama errors

["Juraj Linkeš" <juraj.linkes@pantheon.tech>]

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, December 6, 2021 2:56 PM
> To: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Cc: Tu, Lijuan <lijuan.tu@intel.com>; Owen Hilyard <ohilyard@iol.unh.edu>;
> dts@dpdk.org
> Subject: Re: [PATCH v1] framework/dut: fix pylama errors
> 
> On Mon, Dec 6, 2021 at 1:14 PM Juraj Linkeš <juraj.linkes@pantheon.tech>
> wrote:
> > @@ -540,6 +542,19 @@ class Dut(Crb):
> >          except AttributeError:
> >              self.logger.error("%s is not implemented" % function_name)
> >
> > +    def get_def_rte_config(self, config):
> > +        """
> > +        Get RTE configuration from config/defconfig_*.
> > +        """
> > +        out = self.send_expect("cat config/defconfig_%s | sed '/^#/d' | sed
> '/^\s*$/d'"
> > +                                        % self.target, "# ")
> 
> Is this part still needed?
> 

Sorry for the delayed reply, the mail got lost in my inbox somehow.
Even if this was needed, I wouldn't really want to do it in this patch, as that would be a bigger than necessary change to address the errors.
But in any case, Lijuan, Jun, is this still needed? I remember you mentioning that DTS is used to test older DPDK versions.

> > +
> > +        def_rte_config = re.findall(config+'=(\S+)', out)
> > +        if def_rte_config:
> > +            return def_rte_config[0]
> > +        else:
> > +            return None
> > +
> 
> 
> --
> David Machand
>