test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V2]test_plans/cvl_advanced_iavf_rss_test_plan:delete steps after destroying rss rules
@ 2021-01-28 15:56 qifu
  2021-02-02  5:48 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: qifu @ 2021-01-28 15:56 UTC (permalink / raw)
  To: dts; +Cc: qifu

synced with developer, the behavior after destroy rss rules are not unified.
so delete the steps after destroying rss rules. 

Signed-off-by: qifu <qi.fu@intel.com>
---
 .../cvl_advanced_iavf_rss_test_plan.rst       | 78 +------------------
 1 file changed, 3 insertions(+), 75 deletions(-)

diff --git a/test_plans/cvl_advanced_iavf_rss_test_plan.rst b/test_plans/cvl_advanced_iavf_rss_test_plan.rst
index c4661550..6376a140 100644
--- a/test_plans/cvl_advanced_iavf_rss_test_plan.rst
+++ b/test_plans/cvl_advanced_iavf_rss_test_plan.rst
@@ -334,9 +334,8 @@ all the test cases run the same test steps as below:
    check the received packet have same hash value with the basic packet.
    check the packet is distributed to queues by rss.
    note: if there is not this type packet in the case, omit this step.
-6. destroy the rule and list rule.
-7. send same packet with step 3.
-   check the received packet have different hash value with basic packet.
+6. destroy the rule and list rule. check the flow list has no rule.
+
 
 Test case: MAC_IPV4
 ===================
@@ -1503,7 +1502,7 @@ all the test cases run the same test steps as below:
    note: if there is not this type packet in the case, omit this step.
 6. destroy the rule and list rule.
 7. send same packets with step 2.
-   check the received packets have different hash value, or have no hash value.
+   check the received packets have different hash value.
 
 Test case: symmetric MAC_IPV4
 =============================
@@ -1760,40 +1759,6 @@ Subcase 1: two rules with same pattern but different hash input set, not hit def
 
    check the hash value is different from the first packet.
 
-5. destroy the rule 1::
-
-     testpmd> flow destroy 0 rule 1
-     testpmd> flow list 0
-
-   check the rule 1 not exists in the list.
-   send a MAC_IPV4_UDP packet, you can find it hit default ipv4 profile::
-
-     sendp([Ether(dst="00:11:22:33:44:55")/IP(src="192.168.0.3",dst="192.168.0.5")/UDP(dport=45)/Raw("x"*480)], iface="enp134s0f0")
-
-   change the fields [Source IP] or [Dest IP], send a packet::
-
-     sendp([Ether(dst="00:11:22:33:44:55")/IP(src="192.168.0.7",dst="192.168.0.5")/UDP(dport=45)/Raw("x"*480)], iface="enp134s0f0")
-     sendp([Ether(dst="00:11:22:33:44:55")/IP(src="192.168.0.3",dst="192.168.0.9")/UDP(dport=45)/Raw("x"*480)], iface="enp134s0f0")
-     sendp([Ether(dst="00:11:22:33:44:55")/IP(src="192.168.0.7",dst="192.168.0.9")/UDP(dport=45)/Raw("x"*480)], iface="enp134s0f0")
-
-   check the hash values of the last two packets are different from the first packet.
-   destroy the rule 0::
-
-     testpmd> flow destroy 0 rule 0
-     testpmd> flow list 0
-
-   check the rule 0 not exists in the list.
-   send a MAC_IPV4_UDP packet, you can find it hit default ipv4 profile::
-
-     sendp([Ether(dst="00:11:22:33:44:55")/IP(src="192.168.0.3",dst="192.168.0.5")/UDP(dport=45)/Raw("x"*480)], iface="enp134s0f0")
-
-   change the fields [Source IP] or [Dest IP], send a packet::
-
-     sendp([Ether(dst="00:11:22:33:44:55")/IP(src="192.168.0.7",dst="192.168.0.5")/UDP(dport=45)/Raw("x"*480)], iface="enp134s0f0")
-     sendp([Ether(dst="00:11:22:33:44:55")/IP(src="192.168.0.3",dst="192.168.0.9")/UDP(dport=45)/Raw("x"*480)], iface="enp134s0f0")
-     sendp([Ether(dst="00:11:22:33:44:55")/IP(src="192.168.0.7",dst="192.168.0.9")/UDP(dport=45)/Raw("x"*480)], iface="enp134s0f0")
-
-   check the hash values of the last two packets are different from the first packet.
 
 Subcase 2: two rules with same pattern but different hash input set, hit default profile
 ----------------------------------------------------------------------------------------
@@ -1842,17 +1807,6 @@ Subcase 2: two rules with same pattern but different hash input set, hit default
 
    check the hash value is different from the first packet.
 
-5. destroy the rule 1::
-
-     testpmd> flow destroy 0 rule 1
-     testpmd> flow list 0
-
-   check the rule 1 not exists in the list.
-   send the MAC_IPV4_PAY packet::
-
-     sendp([Ether(dst="00:11:22:33:44:55")/IP(src="192.168.0.3",dst="192.168.0.5")/Raw("x"*480)], iface="enp134s0f0")
-
-   check the hash value is not exist.
 
 Subcase 3: two rules, scope smaller created first, and the larger one created later
 -----------------------------------------------------------------------------------
@@ -1901,19 +1855,6 @@ Subcase 3: two rules, scope smaller created first, and the larger one created la
 
    check the hash value is the same as the first packet.
 
-5. destroy the rule 1::
-
-     testpmd> flow destroy 0 rule 1
-     testpmd> flow list 0
-
-   check the rule 1 not exists in the list.
-   repeat step 2, get the same result.
-   destroy the rule 0::
-
-     testpmd> flow destroy 0 rule 0
-     testpmd> flow list 0
-
-   send a MAC_IPV4_UDP_PAY packet, check the hash values not exists.
 
 Subcase 4: two rules, scope larger created first, and the smaller one created later
 -----------------------------------------------------------------------------------
@@ -1962,16 +1903,3 @@ Subcase 4: two rules, scope larger created first, and the smaller one created la
 
    check the hash value is the same as the first packet.
 
-5. destroy the rule 1::
-
-     testpmd> flow destroy 0 rule 1
-     testpmd> flow list 0
-
-   check the rule 1 not exists in the list.
-   repeat step 2, hit ipv4 profile, get the same result.
-   destroy the rule 0::
-
-     testpmd> flow destroy 0 rule 0
-     testpmd> flow list 0
-
-   send a MAC_IPV4_UDP_PAY packet, check the hash values not exists.
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V2]test_plans/cvl_advanced_iavf_rss_test_plan:delete steps after destroying rss rules
  2021-01-28 15:56 [dts] [PATCH V2]test_plans/cvl_advanced_iavf_rss_test_plan:delete steps after destroying rss rules qifu
@ 2021-02-02  5:48 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2021-02-02  5:48 UTC (permalink / raw)
  To: Fu, Qi, dts; +Cc: Fu, Qi

> synced with developer, the behavior after destroy rss rules are not unified.
> so delete the steps after destroying rss rules.
> 
> Signed-off-by: qifu <qi.fu@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-02  5:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-28 15:56 [dts] [PATCH V2]test_plans/cvl_advanced_iavf_rss_test_plan:delete steps after destroying rss rules qifu
2021-02-02  5:48 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git