From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8B03A0487 for ; Mon, 1 Jul 2019 04:37:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 988472AB; Mon, 1 Jul 2019 04:37:23 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 3B04A23D for ; Mon, 1 Jul 2019 04:37:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jun 2019 19:37:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,437,1557212400"; d="scan'208";a="153943847" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 30 Jun 2019 19:37:20 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 30 Jun 2019 19:37:20 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 30 Jun 2019 19:37:19 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.232]) with mapi id 14.03.0439.000; Mon, 1 Jul 2019 10:37:18 +0800 From: "Wu, ChangqingX" To: "dts@dpdk.org" CC: "Yao, Lei A" Thread-Topic: [dts][PATCH V2] tests/kni: remove case ethtool from kni Thread-Index: AQHVL7JbNnz85XhraEugZHyifOunGaa1CcWA Date: Mon, 1 Jul 2019 02:37:18 +0000 Message-ID: <7F81DD3887C58F49A6B2EFEC3C28E22E0B720842@SHSMSX101.ccr.corp.intel.com> References: <1561947391-113349-1-git-send-email-changqingx.wu@intel.com> In-Reply-To: <1561947391-113349-1-git-send-email-changqingx.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] tests/kni: remove case ethtool from kni X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Hi. Would you acked by this patch? Thanks. changqingx -----Original Message----- From: Wu, ChangqingX=20 Sent: Monday, July 1, 2019 10:17 AM To: dts@dpdk.org Cc: Wu, ChangqingX Subject: [dts][PATCH V2] tests/kni: remove case ethtool from kni kni remove ethtool support from dpdk:ea6b39b5b847655cf65f283d3cc25d7ab629d0= 39 =20 Signed-off-by: changqingxwu --- tests/TestSuite_kni.py | 87 ------------------------------------------ 1 file changed, 87 deletions(-) diff --git a/tests/TestSuite_kni.py b/tests/TestSuite_kni.py index 6bf388c.= .7969464 100644 --- a/tests/TestSuite_kni.py +++ b/tests/TestSuite_kni.py @@ -659,93 +659,6 @@ class TestKni(TestCase): self.verify("%d packets captured" % len(packets_to_send) in ou= t, "Wrong number of packets captured") =20 - def test_ethtool(self): - """ - Ethtool support KNI. - """ - - # Ports and cores configuration set in set_up_all function - # For each virtual interface perform the following operations - for port in self.config['ports']: - - virtual_interface =3D self.virtual_interface_name(port) - - # Request settings - out =3D self.dut.send_expect("ethtool %s" % virtual_interface, - "# ") - self.verify("Settings for %s" % virtual_interface in out, - "ethtool not supported") - self.verify("Operation not supported" not in out, - "ethtool not supported") - - # Request driver information - out =3D self.dut.send_expect("ethtool -i %s" % virtual_interfa= ce, - "# ") - self.verify("driver: ixgbe" or "driver: igb" in out, - "'ethtool -i' not supported") - self.verify("Operation not supported" not in out, - "'ethtool -i' not supported") - - # Request pause parameters - with open("/usr/include/linux/ethtool.h", "r") as ethtool_h: - ethtool_contents =3D ethtool_h.read() - GSET =3D "ETHTOOL_GLINKSETTINGS" - SSET =3D "ETHTOOL_SLINKSETTINGS" - if (GSET in ethtool_contents) and (SSET in ethtool_content= s): - out =3D self.dut.send_expect("ethtool -a %s" % virtual= _interface, - "# ") - self.verify("Pause parameters for %s" % virtual_interf= ace in out, - "'ethtool -a' not supported") - self.verify("Operation not supported" not in out, - "ethtool '-a' not supported") - - # Request statistics - out =3D self.dut.send_expect("ethtool -S %s" % virtual_interfa= ce, - "# ") - self.verify("NIC statistics" in out, - "'ethtool -S' not supported") - self.verify("Operation not supported" not in out, - "ethtool '-S' not supported") - - # Request features status - out =3D self.dut.send_expect("ethtool -k %s" % virtual_interfa= ce, "# ") - self.verify(("Features for %s" % virtual_interface in out) or - ("Offload parameters for %s" % - virtual_interface in out), - "'ethtool -k' not supported") - self.verify("Operation not supported" not in out, - "'ethtool -k' not supported") - - # Request ring parameters - out =3D self.dut.send_expect("ethtool -g %s" % virtual_interfa= ce, - "# ") - self.verify("Ring parameters for %s" % virtual_interface in ou= t, - "'ethtool -g' not supported") - self.verify("Operation not supported" not in out, - "'ethtool -g' not supported") - - # Request coalesce parameters. NOT SUPPORTED - out =3D self.dut.send_expect("ethtool -c %s" % virtual_interfa= ce, - "# ") - self.verify("Operation not supported" in out, - "'ethtool -c' seems to be supported. Check it.") - - # Request register dump - out =3D self.dut.send_expect("ethtool -d %s" % virtual_interfa= ce, - "# ") - expectstring =3D "0x00000: CTRL.*0x00008: STATUS" - self.verify(len(re.findall(expectstring, out, re.DOTALL)) > 0,= "'ethtool -d' not supported") - self.verify("Operation not supported" not in out, - "'ethtool -d' not supported") - - # Request eeprom dump - out =3D self.dut.send_expect("ethtool -e %s" % virtual_interfa= ce, - "# ") - self.verify("Offset" and "Values" in out, - "'ethtool -e' not support") - self.verify("Operation not supported" not in out, - "'ethtool -e' not support") - def test_statistics(self): """ KNI Statistics test. -- 2.17.2