test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Ling, WeiX" <weix.ling@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Ling, WeiX" <weix.ling@intel.com>
Subject: Re: [dts] [PATCH V1] tests/vhost_virtio_user_interrupt:Add -a option to use expect pci to start testpmd
Date: Thu, 21 Jan 2021 07:23:04 +0000	[thread overview]
Message-ID: <7ca522b16742423a838f478adefa7107@intel.com> (raw)
In-Reply-To: <20210114144805.1899603-1-weix.ling@intel.com>

> 
> Add -a option to use expect pci to start testpmd.
> 
> Signed-off-by: Ling Wei <weix.ling@intel.com>
> ---
>  tests/TestSuite_vhost_virtio_user_interrupt.py | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_vhost_virtio_user_interrupt.py
> b/tests/TestSuite_vhost_virtio_user_interrupt.py
> index 9f89c460..be02ee52 100644
> --- a/tests/TestSuite_vhost_virtio_user_interrupt.py
> +++ b/tests/TestSuite_vhost_virtio_user_interrupt.py
> @@ -127,17 +127,21 @@ class TestVirtioUserInterrupt(TestCase):
>          testcmd = self.app_testpmd_path + " "
>          vdev = ["net_vhost0,iface=vhost-net,queues=1,client=0"]
>          para = " -- -i --rxq=1 --txq=1"
> +        allow_pci = [self.pci_info]
> +        if dmas:
> +            for item in self.used_cbdma:
> +                allow_pci.append(item)
>          if len(pci) == 0:
>              if dmas:
>                  vdev = ["net_vhost0,iface=vhost-net,queues=1,dmas=[%s]" % dmas]
> -                eal_params =
> self.dut.create_eal_parameters(cores=self.core_list_vhost, vdevs=vdev)
> +                eal_params =
> + self.dut.create_eal_parameters(cores=self.core_list_vhost,
> + ports=allow_pci, vdevs=vdev)
>              else:
> -                eal_params =
> self.dut.create_eal_parameters(cores=self.core_list_vhost,
> ports=[self.pci_info], vdevs=vdev)
> +                eal_params =
> + self.dut.create_eal_parameters(cores=self.core_list_vhost,
> + ports=allow_pci, vdevs=vdev)
>          else:
>              if dmas:
>                  vdev = ["net_vhost0,iface=vhost-
> net,queues=1,client=0,dmas=[%s]" % dmas]
>                  para = " -- -i"
> -                eal_params =
> self.dut.create_eal_parameters(cores=self.core_list_vhost, ports=pci,
> prefix='vhost', vdevs=vdev)
> +                eal_params =
> + self.dut.create_eal_parameters(cores=self.core_list_vhost,
> + ports=allow_pci, prefix='vhost', vdevs=vdev)
>              else:
>                  eal_params =
> self.dut.create_eal_parameters(cores=self.core_list_vhost, prefix='vhost',
> no_pci=True, vdevs=vdev)
>          cmd_vhost_user = testcmd + eal_params + para @@ -160,6 +164,7 @@
> class TestVirtioUserInterrupt(TestCase):
>          self.virtio.send_expect("start", "testpmd>", 20)
> 
>      def check_interrupt_log(self, status):
> +        time.sleep(3)
>          out = self.l3fwd.get_session_before()

    Prefer self.l3fwd.get_session_before(timeout=3) to sleep

>          if status == "waked up":
>              info = "lcore %s is waked up from rx interrupt on port 0 queue 0"
> --
> 2.25.1


      parent reply	other threads:[~2021-01-21  7:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 14:48 Ling Wei
2021-01-14  6:58 ` Ling, WeiX
2021-01-14  7:05   ` Zhao, HaiyangX
2021-01-21  7:23 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ca522b16742423a838f478adefa7107@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=weix.ling@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).