From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5DC5A0C4B; Mon, 12 Jul 2021 07:17:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A25CC40685; Mon, 12 Jul 2021 07:17:59 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id D84344003C for ; Mon, 12 Jul 2021 07:17:57 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10042"; a="209895923" X-IronPort-AV: E=Sophos;i="5.84,232,1620716400"; d="scan'208";a="209895923" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2021 22:17:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,232,1620716400"; d="scan'208";a="486217532" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP; 11 Jul 2021 22:17:55 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 11 Jul 2021 22:17:54 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 12 Jul 2021 13:17:52 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.010; Mon, 12 Jul 2021 13:17:52 +0800 From: "Tu, Lijuan" To: "Sun, QinX" , "dts@dpdk.org" CC: "Sun, QinX" Thread-Topic: [dts] [PATCH V1] tests/cvl_advanced_rss: remove test steps behind the destroy rule Thread-Index: AQHXcvxKlvzxt+h+pkiDCe5bimavoqs+1EbA Date: Mon, 12 Jul 2021 05:17:52 +0000 Message-ID: <7d7c51ed2dd54b41ab6cc617fd520f93@intel.com> References: <20210707152333.19914-1-qinx.sun@intel.com> In-Reply-To: <20210707152333.19914-1-qinx.sun@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/cvl_advanced_rss: remove test steps behind the destroy rule X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" > -----Original Message----- > From: dts On Behalf Of Qin Sun > Sent: 2021=1B$BG/=1B(B7=1B$B7n=1B(B7=1B$BF|=1B(B 23:24 > To: dts@dpdk.org > Cc: Sun, QinX > Subject: [dts] [PATCH V1] tests/cvl_advanced_rss: remove test steps behin= d the > destroy rule >=20 > As dpdk cannot guarantee the operation after destroying the rule, so remo= ve > the test steps behind the destroy rule step >=20 > Signed-off-by: Qin Sun Test script should algin with test plan. Did test plans update? > --- > tests/TestSuite_cvl_advanced_rss.py | 23 ----------------------- > tests/TestSuite_cvl_advanced_rss_pppoe.py | 3 --- > 2 files changed, 26 deletions(-) >=20 > diff --git a/tests/TestSuite_cvl_advanced_rss.py > b/tests/TestSuite_cvl_advanced_rss.py > index 1534eb8d..da756ac1 100644 > --- a/tests/TestSuite_cvl_advanced_rss.py > +++ b/tests/TestSuite_cvl_advanced_rss.py > @@ -6365,13 +6365,6 @@ class AdvancedRSSTest(TestCase): > self.rssprocess.handle_tests(tests, 0) > self.rssprocess.destroy_rule(port_id=3D0, rule_id=3Drule_id_1) > self.rssprocess.check_rule(port_id=3D0) > - tests =3D [ > - { > - 'send_packet': > 'Ether(dst=3D"00:11:22:33:44:55")/IP(src=3D"192.168.0.3",dst=3D"192.168.0= .5")/Raw(" > x"*480)', > - 'action': {'check_no_hash': 'ipv4-pay'}, > - }, > - ] > - self.rssprocess.handle_tests(tests, 0) > self.rssprocess.destroy_rule(port_id=3D0, rule_id=3Drule_id_0) >=20 > # Subcase 3: two rules, scope smaller created first, and the lar= ger one > created later @@ -6411,15 +6404,7 @@ class AdvancedRSSTest(TestCase): > ] > self.rssprocess.handle_tests(tests, 0) > self.rssprocess.destroy_rule(port_id=3D0, rule_id=3Drule_id_1) > - self.rssprocess.handle_tests(tests_3, 0) > self.rssprocess.destroy_rule(port_id=3D0, rule_id=3Drule_id_0) > - tests =3D [ > - { > - 'send_packet': > 'Ether(dst=3D"00:11:22:33:44:55")/IP(src=3D"192.168.0.3",dst=3D"192.168.0= .5")/UDP(s > port=3D23, dport=3D45)/Raw("x"*480)', > - 'action': {'check_no_hash': 'ipv4-udp-pay'}, > - }, > - ] > - self.rssprocess.handle_tests(tests, 0) >=20 > # Subcase 4: two rules, scope larger created first, and the smal= ler one > created later > self.logger.info('=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3DTest sub case: multirules subcase 4 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D') @@ -6458,15 +6443,7 @@= class > AdvancedRSSTest(TestCase): > ] > self.rssprocess.handle_tests(tests, 0) > self.rssprocess.destroy_rule(port_id=3D0, rule_id=3Drule_id_1) > - self.rssprocess.handle_tests(tests_4, 0) > self.rssprocess.destroy_rule(port_id=3D0, rule_id=3Drule_id_0) > - tests =3D [ > - { > - 'send_packet': > 'Ether(dst=3D"00:11:22:33:44:55")/IP(src=3D"192.168.0.3",dst=3D"192.168.0= .5")/UDP(s > port=3D23, dport=3D45)/Raw("x"*480)', > - 'action': {'check_no_hash': 'ipv4-udp-pay'}, > - }, > - ] > - self.rssprocess.handle_tests(tests, 0) > self.verify(not self.rssprocess.error_msgs, 'some subcases faile= d') >=20 > def tear_down(self): > diff --git a/tests/TestSuite_cvl_advanced_rss_pppoe.py > b/tests/TestSuite_cvl_advanced_rss_pppoe.py > index 0529165a..2d3e226e 100644 > --- a/tests/TestSuite_cvl_advanced_rss_pppoe.py > +++ b/tests/TestSuite_cvl_advanced_rss_pppoe.py > @@ -4710,12 +4710,9 @@ class Advanced_rss_pppoe(TestCase): > # destory rule 1 > self.rsspro.destroy_rule(rule_id=3D1) > self.rsspro.check_rule(rule_list=3D['1'], stats=3DFalse) > - pkt_list[1], pkt_list[2] =3D pkt_list[2], pkt_list[1] > - self._send_pkt_action(pkt_list, action_list=3Daction_list1) > # destory rule 0 > self.rsspro.destroy_rule(rule_id=3D0) > self.rsspro.check_rule(rule_list=3D['0'], stats=3DFalse) > - self._send_pkt_action([pkt_list[0]], action_list=3Daction_list2) >=20 > def test_two_rules_smaller_first_larger_later(self, ): > """ > -- > 2.17.1