test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/userspace_ethtool: modify the check method of mac
@ 2021-09-16  8:23 Jiale Song
  2021-09-27  6:29 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Jiale Song @ 2021-09-16  8:23 UTC (permalink / raw)
  To: dts; +Cc: Jiale Song

the case check failed because the mac echoed by the "macaddr" command of dpdk-ethtool 
changed to uppercase letters. modify the script to solve the problem

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 mode change 100644 => 100755 tests/TestSuite_userspace_ethtool.py

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
old mode 100644
new mode 100755
index 4536b7d..9ae84c0
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -510,7 +510,7 @@ class TestUserspaceEthtool(TestCase):
             port = self.ports[index]
             mac = self.dut.ports_info[port]['mac']
             dump_mac = self.strip_mac(index)
-            self.verify(mac == dump_mac, "Userspace tool failed to dump mac")
+            self.verify(mac.lower() == dump_mac.lower(), "Userspace tool failed to dump mac")
             self.dut.send_expect("macaddr %d %s" % (port, valid_mac), "EthApp>")
             dump_mac = self.strip_mac(index)
             self.verify(dump_mac == valid_mac, "Userspace tool failed to set mac")
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/userspace_ethtool: modify the check method of mac
  2021-09-16  8:23 [dts] [PATCH V1] tests/userspace_ethtool: modify the check method of mac Jiale Song
@ 2021-09-27  6:29 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2021-09-27  6:29 UTC (permalink / raw)
  To: Jiale, SongX, dts; +Cc: Jiale, SongX


> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Jiale Song
> Sent: 2021年9月16日 16:24
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/userspace_ethtool: modify the check method of
> mac
> 
> the case check failed because the mac echoed by the "macaddr" command of
> dpdk-ethtool changed to uppercase letters. modify the script to solve the
> problem
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>

Applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-27  6:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16  8:23 [dts] [PATCH V1] tests/userspace_ethtool: modify the check method of mac Jiale Song
2021-09-27  6:29 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git