From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24BEAA04B6; Tue, 13 Oct 2020 04:13:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1743B1D9FB; Tue, 13 Oct 2020 04:13:30 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 095C51D9DE for ; Tue, 13 Oct 2020 04:13:27 +0200 (CEST) IronPort-SDR: lMPKgeQQBQq5h90qEa1waYtuQvXl37bobIVChjiXZR9kHON/ef6ilwMO/AIKvbPizCzP8w8/9K 3M7zYF1fVyfg== X-IronPort-AV: E=McAfee;i="6000,8403,9772"; a="250527909" X-IronPort-AV: E=Sophos;i="5.77,369,1596524400"; d="scan'208";a="250527909" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2020 19:13:25 -0700 IronPort-SDR: 05AhEG8QJZCDTi1yAE8Nn1pzckH7WqHsfxVoAZpXb8ui353Yb4ioR16CSSyhPI9TBQmqYlFy3t hJRtzesAJcjA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,369,1596524400"; d="scan'208";a="350946053" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga002.fm.intel.com with ESMTP; 12 Oct 2020 19:13:25 -0700 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 12 Oct 2020 19:13:24 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 13 Oct 2020 10:13:21 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Tue, 13 Oct 2020 10:13:21 +0800 From: "Tu, Lijuan" To: "Chen, LingliX" , "Ma, LihongX" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1] tests/TestSuite_shutdown_api:fixed differences brought about by speed units Thread-Index: AQHWoGKE3lh/DGy6uEmtEpUpNpHz3KmTAiuAgAHIXpA= Date: Tue, 13 Oct 2020 02:13:21 +0000 Message-ID: <808cebc7ccb847db947c2eb3232e6d36@intel.com> References: <20200928071329.8897-1-linglix.chen@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/TestSuite_shutdown_api:fixed differences brought about by speed units X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" > > Can you write clearly why do we need to do this change ? >=20 > if change Link speed is1000 or 10000,the DUT's Link speed is 1 Gbps or 10= Gbps, > if change Link speed is100, the DUT's Link speed is 100 Mbps It's not a good idea to get unit by value, if the speed is 1000Gbps(althoug= h we don't have it now, but soon in future), it can't know it is Gbps or Mb= ps. Generally speaking, get unit first and then verify value.