test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/iavf_rss_protocol_agnostic_flow: optimize script
@ 2023-02-24 16:51 Jiale Song
  2023-03-07  3:55 ` lijuan.tu
  0 siblings, 1 reply; 2+ messages in thread
From: Jiale Song @ 2023-02-24 16:51 UTC (permalink / raw)
  To: dts; +Cc: Jiale Song

the correct error information is not obtained.the error message comes 
from "rte_flow_common.RssProcessing.error_msgs"."self.error_msgs" does 
not get the corresponding error message.

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_iavf_rss_protocol_agnostic_flow.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_iavf_rss_protocol_agnostic_flow.py b/tests/TestSuite_iavf_rss_protocol_agnostic_flow.py
index 1a6fb2c3..e8d8d58f 100644
--- a/tests/TestSuite_iavf_rss_protocol_agnostic_flow.py
+++ b/tests/TestSuite_iavf_rss_protocol_agnostic_flow.py
@@ -484,7 +484,6 @@ class TestIavfRssProtocolAgnosticFlow(TestCase):
     def handle_rss_case(self, case_info):
         # clear hash_records before each sub case
         self.hash_records = {}
-        self.error_msgs = []
         self.current_saved_hash = ""
         sub_case_name = case_info.get("sub_casename")
         self.logger.info(
@@ -516,10 +515,12 @@ class TestIavfRssProtocolAgnosticFlow(TestCase):
             self.rsspro.destroy_rule(port_id=port_id, rule_id=rule_ids)
             self.rsspro.check_rule(port_id=port_id, stats=False)
             self.rsspro.handle_tests(case_info["post-test"], port_id=port_id)
-        if self.error_msgs:
+        if self.rsspro.error_msgs:
             self.verify(
                 False,
-                " ".join([errs.replace("'", " ") for errs in self.error_msgs[:500]]),
+                " ".join(
+                    [errs.replace("'", " ") for errs in self.rsspro.error_msgs[:500]]
+                ),
             )
 
     def rte_flow(self, case_list, func_name, **kwargs):
@@ -643,7 +644,6 @@ class TestIavfRssProtocolAgnosticFlow(TestCase):
         # create rule
         self.rsspro.create_rule(rules, check_stats=True)
         self.rsspro.error_msgs = []
-        self.rsspro.error_msgs = []
         self.handle_tests(tests, port_id=dPort, tport_id=tPort)
         if self.rsspro.error_msgs:
             self.verify(
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dts] [PATCH V1] tests/iavf_rss_protocol_agnostic_flow: optimize script
  2023-02-24 16:51 [dts] [PATCH V1] tests/iavf_rss_protocol_agnostic_flow: optimize script Jiale Song
@ 2023-03-07  3:55 ` lijuan.tu
  0 siblings, 0 replies; 2+ messages in thread
From: lijuan.tu @ 2023-03-07  3:55 UTC (permalink / raw)
  To: dts, Jiale Song; +Cc: Jiale Song

On Fri, 24 Feb 2023 16:51:50 +0000, Jiale Song <songx.jiale@intel.com> wrote:
> the correct error information is not obtained.the error message comes 
> from "rte_flow_common.RssProcessing.error_msgs"."self.error_msgs" does 
> not get the corresponding error message.
> 
> Signed-off-by: Jiale Song <songx.jiale@intel.com>


Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-07  3:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-24 16:51 [dts] [PATCH V1] tests/iavf_rss_protocol_agnostic_flow: optimize script Jiale Song
2023-03-07  3:55 ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).