Re: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case failures in vf_reset

["Liu, Yong" <yong.liu@intel.com>]

Hi Herbert,
Why required driver is not insmod be previous setup?
As one principle, we want to limit the influence of environment change in the suite.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Herbert Guan
> Sent: Wednesday, February 14, 2018 2:29 PM
> To: dts@dpdk.org
> Cc: Herbert Guan <herbert.guan@arm.com>
> Subject: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case failures in
> vf_reset
> 
> 1) Clear port stats before send/recv test packets
> 2) Ensure igb_uio driver is installed if driver='igb_uio'
> 
> 
> Signed-off-by: Herbert Guan <herbert.guan@arm.com>
> ---
>  tests/TestSuite_vf_packet_rxtx.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/TestSuite_vf_packet_rxtx.py
> b/tests/TestSuite_vf_packet_rxtx.py
> index 63f4820..f0b7721 100644
> --- a/tests/TestSuite_vf_packet_rxtx.py
> +++ b/tests/TestSuite_vf_packet_rxtx.py
> @@ -125,6 +125,9 @@ class TestVfPacketRxtx(TestCase):
>      def packet_rx_tx(self, driver='default'):
> 
>          if driver == 'igb_uio':
> +            # ensure igb_uio driver is installed
> +            self.dut.send_expect('(lsmod | grep uio) || (modprobe uio)',
> '#')
> +            self.dut.send_expect('(lsmod | grep igb_uio) ||
> (insmod ./%s/kmod/igb_uio.ko)' % self.target,'#')
>              self.setup_2pf_2vf_1vm_env(driver='igb_uio')
>          else:
>              self.setup_2pf_2vf_1vm_env(driver='')
> @@ -279,6 +282,7 @@ class TestVfPacketRxtx(TestCase):
>          rx_port = tx_port
> 
>          dst_mac = pmd0_vf0_mac
> +        self.vm0_testpmd.execute_cmd('clear port stats all')
>          self.tester.sendpkt_bg(tx_port, dst_mac)
> 
>          #vf port stop/start can trigger reset action
> --
> 1.8.3.1