From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E71354C77 for ; Fri, 2 Mar 2018 03:07:35 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Mar 2018 18:07:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,409,1515484800"; d="scan'208";a="21932292" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 01 Mar 2018 18:07:33 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Mar 2018 18:07:33 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 1 Mar 2018 18:07:32 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by shsmsx102.ccr.corp.intel.com ([169.254.2.124]) with mapi id 14.03.0319.002; Fri, 2 Mar 2018 10:07:31 +0800 From: "Liu, Yong" To: Herbert Guan , "dts@dpdk.org" Thread-Topic: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case failures in vf_reset Thread-Index: AQHTpV0lN1a2JJzvskiNuGFzd8JXVKO8Sn4w Date: Fri, 2 Mar 2018 02:07:30 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62FA5E0C@SHSMSX103.ccr.corp.intel.com> References: <1518589716-27299-1-git-send-email-herbert.guan@arm.com> In-Reply-To: <1518589716-27299-1-git-send-email-herbert.guan@arm.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGIzYmNlZWMtYTg3NC00YjY2LWI5Y2EtNDlhYzg4ZTk4ZjkwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiIrOE9IMmdxNXRGUmhLWFBZOWZzQzZhQXBueHFBc3NqSWNDNWdaMjR3dDFwUnhUdFJWM1JaczFJR2hodXVMNkJOIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case failures in vf_reset X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2018 02:07:36 -0000 Hi Herbert, Why required driver is not insmod be previous setup? As one principle, we want to limit the influence of environment change in t= he suite. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Herbert Guan > Sent: Wednesday, February 14, 2018 2:29 PM > To: dts@dpdk.org > Cc: Herbert Guan > Subject: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case failures in > vf_reset >=20 > 1) Clear port stats before send/recv test packets > 2) Ensure igb_uio driver is installed if driver=3D'igb_uio' >=20 >=20 > Signed-off-by: Herbert Guan > --- > tests/TestSuite_vf_packet_rxtx.py | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/tests/TestSuite_vf_packet_rxtx.py > b/tests/TestSuite_vf_packet_rxtx.py > index 63f4820..f0b7721 100644 > --- a/tests/TestSuite_vf_packet_rxtx.py > +++ b/tests/TestSuite_vf_packet_rxtx.py > @@ -125,6 +125,9 @@ class TestVfPacketRxtx(TestCase): > def packet_rx_tx(self, driver=3D'default'): >=20 > if driver =3D=3D 'igb_uio': > + # ensure igb_uio driver is installed > + self.dut.send_expect('(lsmod | grep uio) || (modprobe uio)', > '#') > + self.dut.send_expect('(lsmod | grep igb_uio) || > (insmod ./%s/kmod/igb_uio.ko)' % self.target,'#') > self.setup_2pf_2vf_1vm_env(driver=3D'igb_uio') > else: > self.setup_2pf_2vf_1vm_env(driver=3D'') > @@ -279,6 +282,7 @@ class TestVfPacketRxtx(TestCase): > rx_port =3D tx_port >=20 > dst_mac =3D pmd0_vf0_mac > + self.vm0_testpmd.execute_cmd('clear port stats all') > self.tester.sendpkt_bg(tx_port, dst_mac) >=20 > #vf port stop/start can trigger reset action > -- > 1.8.3.1