From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 85B1E5F16 for ; Fri, 2 Mar 2018 09:00:34 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2018 00:00:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,411,1515484800"; d="scan'208";a="208304671" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 02 Mar 2018 00:00:32 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 2 Mar 2018 00:00:32 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Fri, 2 Mar 2018 16:00:30 +0800 From: "Liu, Yong" To: Herbert Guan , "dts@dpdk.org" CC: nd Thread-Topic: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case failures in vf_reset Thread-Index: AQHTpV0lN1a2JJzvskiNuGFzd8JXVKO8Sn4w///MQACAAJJoEA== Date: Fri, 2 Mar 2018 08:00:30 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62FA71F5@SHSMSX103.ccr.corp.intel.com> References: <1518589716-27299-1-git-send-email-herbert.guan@arm.com> <86228AFD5BCD8E4EBFD2B90117B5E81E62FA5E0C@SHSMSX103.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjJiOTQ1MWUtYjUzZC00NDM3LTkwNjItZTgzYTAxODgzZjQ2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJLU2pLM1N2UnJjWndjU0k0ZE1JMDVMQUh1cFltRnlQMkRXSkZUTWg0SGd0V0pCOG5kQkJmOVhaWGNERThkelQyIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case failures in vf_reset X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2018 08:00:35 -0000 Herbert, We have also incurred your problem in some VF related cases. Look like most= VF related cases need one default module (igb_uio or vfio noiommu) in VM. As default module should be bound with VM, I'd like to add one global optio= n for this default module. Meanwhile test suite can change the default value in their own configuratio= n. Thanks, Marvin > -----Original Message----- > From: Herbert Guan [mailto:Herbert.Guan@arm.com] > Sent: Friday, March 02, 2018 2:58 PM > To: Liu, Yong ; dts@dpdk.org > Cc: nd > Subject: RE: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case failure= s > in vf_reset >=20 > Marvin, >=20 > When the execution config file selects driver mode to a certain mode (vfi= o, > igb_uio, etc.), then both host and VM NICs will use this mode in case > setup. If some case need VM to use the igb_uio mode, regardless of the > driver mode in execution configure file, we need to ensure the required > drivers have been installed. >=20 > If we want to restore the environment, we need to add some extra logic to > the case script. If the uio or igb_uio driver is not installed, then > install it and make flag. This script need to remove installed drivers > that were not installed before running the test. >=20 > Best regards, > Herbert >=20 > > -----Original Message----- > > From: Liu, Yong [mailto:yong.liu@intel.com] > > Sent: Friday, March 2, 2018 10:08 > > To: Herbert Guan ; dts@dpdk.org > > Subject: RE: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case > failures in > > vf_reset > > > > Hi Herbert, > > Why required driver is not insmod be previous setup? > > As one principle, we want to limit the influence of environment change > in the > > suite. > > > > Thanks, > > Marvin > > > > > -----Original Message----- > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Herbert Guan > > > Sent: Wednesday, February 14, 2018 2:29 PM > > > To: dts@dpdk.org > > > Cc: Herbert Guan > > > Subject: [dts] [PATCH v1] tests/vf_packet_rxtx: fix test case failure= s > > > in vf_reset > > > > > > 1) Clear port stats before send/recv test packets > > > 2) Ensure igb_uio driver is installed if driver=3D'igb_uio' > > > > > > > > > Signed-off-by: Herbert Guan > > > --- > > > tests/TestSuite_vf_packet_rxtx.py | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/tests/TestSuite_vf_packet_rxtx.py > > > b/tests/TestSuite_vf_packet_rxtx.py > > > index 63f4820..f0b7721 100644 > > > --- a/tests/TestSuite_vf_packet_rxtx.py > > > +++ b/tests/TestSuite_vf_packet_rxtx.py > > > @@ -125,6 +125,9 @@ class TestVfPacketRxtx(TestCase): > > > def packet_rx_tx(self, driver=3D'default'): > > > > > > if driver =3D=3D 'igb_uio': > > > + # ensure igb_uio driver is installed > > > + self.dut.send_expect('(lsmod | grep uio) || (modprobe > > > + uio)', > > > '#') > > > + self.dut.send_expect('(lsmod | grep igb_uio) || > > > (insmod ./%s/kmod/igb_uio.ko)' % self.target,'#') > > > self.setup_2pf_2vf_1vm_env(driver=3D'igb_uio') > > > else: > > > self.setup_2pf_2vf_1vm_env(driver=3D'') > > > @@ -279,6 +282,7 @@ class TestVfPacketRxtx(TestCase): > > > rx_port =3D tx_port > > > > > > dst_mac =3D pmd0_vf0_mac > > > + self.vm0_testpmd.execute_cmd('clear port stats all') > > > self.tester.sendpkt_bg(tx_port, dst_mac) > > > > > > #vf port stop/start can trigger reset action > > > -- > > > 1.8.3.1