* [dts] [PATCH V1] tests/TestSuite_vxlan.py Stop the port after the csum setting
@ 2018-03-08 7:21 zhu,shuai
2018-03-08 9:30 ` Liu, Yong
0 siblings, 1 reply; 5+ messages in thread
From: zhu,shuai @ 2018-03-08 7:21 UTC (permalink / raw)
To: dts; +Cc: zhu,shuai
Need to stop port before configure CSUM offloading.
Refer to dpdk commit:dbc1960b9e700426013b0f35708df568b8790311
Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
tests/TestSuite_vxlan.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
index 17a34d4..ab9f691 100644
--- a/tests/TestSuite_vxlan.py
+++ b/tests/TestSuite_vxlan.py
@@ -657,11 +657,13 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
self.dut.send_expect('vlan set filter off %d' %self.dut_port, "testpmd")
# enable tx checksum offload
self.dut.send_expect("set fwd csum", "testpmd>", 10)
+ self.dut.send_expect("port stop all", "testpmd>")
self.csum_set_type('ip', self.recv_port)
self.csum_set_type('outer-ip', self.recv_port)
self.csum_set_type('udp', self.recv_port)
self.csum_set_type('tcp', self.recv_port)
self.csum_set_type('sctp', self.recv_port)
+ self.dut.send_expect("port start all", "testpmd>")
self.dut.send_expect("csum parse_tunnel on %d" %
self.recv_port, "testpmd>", 10)
--
1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V1] tests/TestSuite_vxlan.py Stop the port after the csum setting
2018-03-08 7:21 [dts] [PATCH V1] tests/TestSuite_vxlan.py Stop the port after the csum setting zhu,shuai
@ 2018-03-08 9:30 ` Liu, Yong
0 siblings, 0 replies; 5+ messages in thread
From: Liu, Yong @ 2018-03-08 9:30 UTC (permalink / raw)
To: Zhu, ShuaiX, dts; +Cc: Zhu, ShuaiX
Shuai,
I think the dpdk reference commit is 597f9fafe. Has merged your patch with correct information.
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Thursday, March 08, 2018 3:22 PM
> To: dts@dpdk.org
> Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_vxlan.py Stop the port after the
> csum setting
>
> Need to stop port before configure CSUM offloading.
> Refer to dpdk commit:dbc1960b9e700426013b0f35708df568b8790311
>
>
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
> tests/TestSuite_vxlan.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
> index 17a34d4..ab9f691 100644
> --- a/tests/TestSuite_vxlan.py
> +++ b/tests/TestSuite_vxlan.py
> @@ -657,11 +657,13 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
> self.dut.send_expect('vlan set filter off %d' %self.dut_port,
> "testpmd")
> # enable tx checksum offload
> self.dut.send_expect("set fwd csum", "testpmd>", 10)
> + self.dut.send_expect("port stop all", "testpmd>")
> self.csum_set_type('ip', self.recv_port)
> self.csum_set_type('outer-ip', self.recv_port)
> self.csum_set_type('udp', self.recv_port)
> self.csum_set_type('tcp', self.recv_port)
> self.csum_set_type('sctp', self.recv_port)
> + self.dut.send_expect("port start all", "testpmd>")
> self.dut.send_expect("csum parse_tunnel on %d" %
> self.recv_port, "testpmd>", 10)
>
> --
> 1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V1] tests/TestSuite_vxlan.py:Stop the port after the csum setting.
2018-02-11 4:06 zhu,shuai
@ 2018-03-08 10:48 ` Liu, Yong
0 siblings, 0 replies; 5+ messages in thread
From: Liu, Yong @ 2018-03-08 10:48 UTC (permalink / raw)
To: zhu,shuai, dts; +Cc: juanx.xia
Shuai,
Please add signed-off-by and commit log in your patch. You can refer to
historical patch's format.
Thanks,
Marvin
On 02/11/2018 12:06 PM, zhu,shuai wrote:
> diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
> index 17a34d4..ab9f691 100644
> --- a/tests/TestSuite_vxlan.py
> +++ b/tests/TestSuite_vxlan.py
> @@ -657,11 +657,13 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
> self.dut.send_expect('vlan set filter off %d' %self.dut_port, "testpmd")
> # enable tx checksum offload
> self.dut.send_expect("set fwd csum", "testpmd>", 10)
> + self.dut.send_expect("port stop all", "testpmd>")
> self.csum_set_type('ip', self.recv_port)
> self.csum_set_type('outer-ip', self.recv_port)
> self.csum_set_type('udp', self.recv_port)
> self.csum_set_type('tcp', self.recv_port)
> self.csum_set_type('sctp', self.recv_port)
> + self.dut.send_expect("port start all", "testpmd>")
> self.dut.send_expect("csum parse_tunnel on %d" %
> self.recv_port, "testpmd>", 10)
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dts] [PATCH V1] tests/TestSuite_vxlan.py:Stop the port after the csum setting
@ 2018-03-08 5:24 zhu,shuai
0 siblings, 0 replies; 5+ messages in thread
From: zhu,shuai @ 2018-03-08 5:24 UTC (permalink / raw)
To: dts; +Cc: zhu,shuai
diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
index 17a34d4..ab9f691 100644
--- a/tests/TestSuite_vxlan.py
+++ b/tests/TestSuite_vxlan.py
@@ -657,11 +657,13 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
self.dut.send_expect('vlan set filter off %d' %self.dut_port, "testpmd")
# enable tx checksum offload
self.dut.send_expect("set fwd csum", "testpmd>", 10)
+ self.dut.send_expect("port stop all", "testpmd>")
self.csum_set_type('ip', self.recv_port)
self.csum_set_type('outer-ip', self.recv_port)
self.csum_set_type('udp', self.recv_port)
self.csum_set_type('tcp', self.recv_port)
self.csum_set_type('sctp', self.recv_port)
+ self.dut.send_expect("port start all", "testpmd>")
self.dut.send_expect("csum parse_tunnel on %d" %
self.recv_port, "testpmd>", 10)
--
1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dts] [PATCH V1] tests/TestSuite_vxlan.py:Stop the port after the csum setting.
@ 2018-02-11 4:06 zhu,shuai
2018-03-08 10:48 ` Liu, Yong
0 siblings, 1 reply; 5+ messages in thread
From: zhu,shuai @ 2018-02-11 4:06 UTC (permalink / raw)
To: dts; +Cc: zhu,shuai
diff --git a/tests/TestSuite_vxlan.py b/tests/TestSuite_vxlan.py
index 17a34d4..ab9f691 100644
--- a/tests/TestSuite_vxlan.py
+++ b/tests/TestSuite_vxlan.py
@@ -657,11 +657,13 @@ class TestVxlan(TestCase, IxiaPacketGenerator):
self.dut.send_expect('vlan set filter off %d' %self.dut_port, "testpmd")
# enable tx checksum offload
self.dut.send_expect("set fwd csum", "testpmd>", 10)
+ self.dut.send_expect("port stop all", "testpmd>")
self.csum_set_type('ip', self.recv_port)
self.csum_set_type('outer-ip', self.recv_port)
self.csum_set_type('udp', self.recv_port)
self.csum_set_type('tcp', self.recv_port)
self.csum_set_type('sctp', self.recv_port)
+ self.dut.send_expect("port start all", "testpmd>")
self.dut.send_expect("csum parse_tunnel on %d" %
self.recv_port, "testpmd>", 10)
--
1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-08 9:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-08 7:21 [dts] [PATCH V1] tests/TestSuite_vxlan.py Stop the port after the csum setting zhu,shuai
2018-03-08 9:30 ` Liu, Yong
-- strict thread matches above, loose matches on Subject: below --
2018-03-08 5:24 [dts] [PATCH V1] tests/TestSuite_vxlan.py:Stop " zhu,shuai
2018-02-11 4:06 zhu,shuai
2018-03-08 10:48 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).