From: "Liu, Yong" <yong.liu@intel.com>
To: Joyce Kong <Joyce.Kong@arm.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset
Date: Mon, 12 Mar 2018 01:38:49 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62FBD7E2@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <AM2PR08MB0178D3BD1DEBFA9EAE1B18FA92DE0@AM2PR08MB0178.eurprd08.prod.outlook.com>
Joyce,
There's still some kind of possibility that PF will transmit packets in the test which will cause unexpected result.
It's better to disable network-manager on the PF device. But if this solution is workable for you, I can also merge it.
Thanks,
Marvin
> -----Original Message-----
> From: Joyce Kong [mailto:Joyce.Kong@arm.com]
> Sent: Friday, March 09, 2018 7:39 PM
> To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org
> Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> failures in vf_reset
>
> Hi Marvin,
>
> DUT PF would send dhcp protocol packet to VF before tester transmission,
> and that's why we need to clear ports at the start.
>
> Best Regards,
> Joyce
>
> -----Original Message-----
> From: Liu, Yong [mailto:yong.liu@intel.com]
> Sent: Thursday, March 8, 2018 11:37 AM
> To: Joyce Kong <Joyce.Kong@arm.com>; dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> failures in vf_reset
>
> Hi Joyce,
> Could you please figure out why need to clean the counter before tester
> transmission? It should be no packet sent to VF before that moment.
>
> Thanks,
> Marvin
>
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Joyce Kong
> > Sent: Tuesday, March 06, 2018 3:47 PM
> > To: dts@dpdk.org
> > Cc: Joyce Kong <joyce.kong@arm.com>
> > Subject: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case
> > failures in vf_reset
> >
> > Clear port stats before counting port info
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > ---
> > tests/TestSuite_vf_packet_rxtx.py | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/TestSuite_vf_packet_rxtx.py
> > b/tests/TestSuite_vf_packet_rxtx.py
> > index 63f4820..6a29d23 100644
> > --- a/tests/TestSuite_vf_packet_rxtx.py
> > +++ b/tests/TestSuite_vf_packet_rxtx.py
> > @@ -279,6 +279,7 @@ class TestVfPacketRxtx(TestCase):
> > rx_port = tx_port
> >
> > dst_mac = pmd0_vf0_mac
> > + self.vm0_testpmd.execute_cmd('clear port stats all')
> > self.tester.sendpkt_bg(tx_port, dst_mac)
> >
> > #vf port stop/start can trigger reset action
> > --
> > 1.8.3.1
>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
next prev parent reply other threads:[~2018-03-12 1:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 11:38 Joyce Kong
2018-03-12 1:38 ` Liu, Yong [this message]
2018-03-12 2:26 ` Joyce Kong
2018-03-12 3:31 ` Liu, Yong
-- strict thread matches above, loose matches on Subject: below --
2018-03-06 7:46 Joyce Kong
2018-03-08 3:36 ` Liu, Yong
2018-03-06 7:33 Joyce Kong
2018-03-06 3:29 Joyce Kong
2018-03-06 3:16 Joyce Kong
2018-03-06 2:39 Joyce Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62FBD7E2@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=Joyce.Kong@arm.com \
--cc=dts@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).