From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 947A519F5 for ; Mon, 12 Mar 2018 04:31:23 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Mar 2018 20:31:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,459,1515484800"; d="scan'208";a="23678338" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 11 Mar 2018 20:31:22 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 11 Mar 2018 20:31:21 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 11 Mar 2018 20:31:21 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.108]) with mapi id 14.03.0319.002; Mon, 12 Mar 2018 11:31:19 +0800 From: "Liu, Yong" To: Joyce Kong , "dts@dpdk.org" Thread-Topic: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset Thread-Index: AdO3mhJVIcWFrM9hQHKVkOJTOaUQ8ACB/KKgAAFoc+AAArHzIA== Date: Mon, 12 Mar 2018 03:31:19 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62FBD8E7@SHSMSX103.ccr.corp.intel.com> References: <86228AFD5BCD8E4EBFD2B90117B5E81E62FBD7E2@SHSMSX103.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjZlNWM1MzktNWQyZC00ZGVhLThiNDUtNjE5OGM5YzIyZGFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJHWDZudVBkUEtXb3dvNWo2Z2todTU1TkVNVDU1dmtXSFhyNkxSVTE3NGsxRjhESFdBWnRpUGxSTjNIaGc4TlBsIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case failures in vf_reset X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Mar 2018 03:31:24 -0000 Joyce, Agreed with you, merged first patch into master branch. Thanks, Marvin > -----Original Message----- > From: Joyce Kong [mailto:Joyce.Kong@arm.com] > Sent: Monday, March 12, 2018 10:26 AM > To: Liu, Yong ; dts@dpdk.org > Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case > failures in vf_reset >=20 > Hi Marvin, >=20 > Clearing port stats is valid on most occasions and we can't always ensure > to disable all network-manager on PF. Overall there's no harm in doing > this. >=20 > Thanks & regards=1B$B!$=1B(B > Joyce >=20 > -----Original Message----- > From: Liu, Yong [mailto:yong.liu@intel.com] > Sent: Monday, March 12, 2018 9:39 AM > To: Joyce Kong ; dts@dpdk.org > Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case > failures in vf_reset >=20 > Joyce, > There's still some kind of possibility that PF will transmit packets in > the test which will cause unexpected result. > It's better to disable network-manager on the PF device. But if this > solution is workable for you, I can also merge it. >=20 > Thanks, > Marvin >=20 > > -----Original Message----- > > From: Joyce Kong [mailto:Joyce.Kong@arm.com] > > Sent: Friday, March 09, 2018 7:39 PM > > To: Liu, Yong ; dts@dpdk.org > > Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case > > failures in vf_reset > > > > Hi Marvin, > > > > DUT PF would send dhcp protocol packet to VF before tester > > transmission, and that's why we need to clear ports at the start. > > > > Best Regards=1B$B!$=1B(B > > Joyce > > > > -----Original Message----- > > From: Liu, Yong [mailto:yong.liu@intel.com] > > Sent: Thursday, March 8, 2018 11:37 AM > > To: Joyce Kong ; dts@dpdk.org > > Cc: Zhao, MeijuanX > > Subject: RE: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case > > failures in vf_reset > > > > Hi Joyce, > > Could you please figure out why need to clean the counter before > > tester transmission? It should be no packet sent to VF before that > moment. > > > > Thanks, > > Marvin > > > > > -----Original Message----- > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Joyce Kong > > > Sent: Tuesday, March 06, 2018 3:47 PM > > > To: dts@dpdk.org > > > Cc: Joyce Kong > > > Subject: [dts] [PATCH 1/2] tests/vf_packet_rxtx: fix test case > > > failures in vf_reset > > > > > > Clear port stats before counting port info > > > > > > Signed-off-by: Joyce Kong > > > --- > > > tests/TestSuite_vf_packet_rxtx.py | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/tests/TestSuite_vf_packet_rxtx.py > > > b/tests/TestSuite_vf_packet_rxtx.py > > > index 63f4820..6a29d23 100644 > > > --- a/tests/TestSuite_vf_packet_rxtx.py > > > +++ b/tests/TestSuite_vf_packet_rxtx.py > > > @@ -279,6 +279,7 @@ class TestVfPacketRxtx(TestCase): > > > rx_port =3D tx_port > > > > > > dst_mac =3D pmd0_vf0_mac > > > + self.vm0_testpmd.execute_cmd('clear port stats all') > > > self.tester.sendpkt_bg(tx_port, dst_mac) > > > > > > #vf port stop/start can trigger reset action > > > -- > > > 1.8.3.1 > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > > confidential and may also be privileged. If you are not the intended > > recipient, please notify the sender immediately and do not disclose > > the contents to any other person, use it for any purpose, or store or > > copy the information in any medium. Thank you. > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy th= e > information in any medium. Thank you.