From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D46502C5E for ; Mon, 19 Mar 2018 09:42:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2018 01:42:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,329,1517904000"; d="scan'208";a="34981227" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 19 Mar 2018 01:42:57 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 19 Mar 2018 01:42:57 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 19 Mar 2018 01:42:57 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.166]) with mapi id 14.03.0319.002; Mon, 19 Mar 2018 16:42:55 +0800 From: "Liu, Yong" To: "Zhao, MeijuanX" , "dts@dpdk.org" CC: "Zhao, MeijuanX" Thread-Topic: [dts] [PATCH V1] tests/vf daemon fix vlan issue Thread-Index: AQHTumsWM0VTPuLTe0GmTLbbQGEtA6PXRfHQ Date: Mon, 19 Mar 2018 08:42:54 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62FC5DAD@SHSMSX103.ccr.corp.intel.com> References: <1520904781-81004-1-git-send-email-meijuanx.zhao@intel.com> In-Reply-To: <1520904781-81004-1-git-send-email-meijuanx.zhao@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjIxMGQ3YTEtODMyYi00N2YzLWFjZmEtYmY0M2E5Mjc3NDcwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJKSVlQVE5OXC9rRlBURWp0UmN6MURtdkxiWElQRjFtTDROcDh2bWpsMEtkdWJUWHpvTlg4VUJnRkZ6S1QwNHlKVyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/vf daemon fix vlan issue X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Mar 2018 08:43:00 -0000 Meijuan, I think DPDK should keep PF/VF vlan related setting same across the NICs.=20 There're lot of special NIC type check in your patch. Please check whether = they are must needed. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan > Sent: Tuesday, March 13, 2018 9:33 AM > To: dts@dpdk.org > Cc: Zhao, MeijuanX > Subject: [dts] [PATCH V1] tests/vf daemon fix vlan issue >=20 > add enable vlan filter parameter, you can refer to dpdk 8b9bd0, > vlan default promiscuous setting is different for different > VF kernel driver >=20 > Signed-off-by: zhao,meijuan > --- > tests/TestSuite_vf_daemon.py | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) >=20 > diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py > index b1ad522..08d6abe 100644 > --- a/tests/TestSuite_vf_daemon.py > +++ b/tests/TestSuite_vf_daemon.py > @@ -562,13 +562,15 @@ class Testvf_daemon(TestCase): > Enable/disable vlan antispoof for a VF from PF > """ > self.check_vf_link_status() > - > + if self.kdriver =3D=3D "ixgbe": > + self.dut_testpmd.execute_cmd('vlan set filter on 0') Why need to enable vlan filter on PF device for ixgbe?=20 > self.vf0_mac =3D self.vm0_testpmd.get_port_mac(0) > vf0_mac_lower =3D self.vf0_mac.lower() > random_vlan =3D random.randint(1, MAX_VLAN) > match_vlan =3D random_vlan > unmatch_vlan =3D (random_vlan + 2) % 4096 > self.vm0_testpmd.execute_cmd('set fwd mac') > + self.vm0_testpmd.execute_cmd('vlan set filter on 0') > self.vm0_testpmd.execute_cmd('start') > #self.dut_testpmd.execute_cmd('rx_vlan add %d port 0 vf 1' % > match_vlan) > self.vm0_testpmd.execute_cmd('rx_vlan add %d 0' % match_vlan) > @@ -607,6 +609,9 @@ class Testvf_daemon(TestCase): > out =3D self.send_and_macstrip(self.vf0_mac) > self.verify(vf0_mac_lower not in out, > "Failed to enable vlan antispoof with no vlan!!!") > + self.vm0_testpmd.execute_cmd('vlan set filter off 0') > + if self.kdriver =3D=3D "ixgbe": > + self.dut_testpmd.execute_cmd('vlan set filter off 0') >=20 >=20 > def test_vlan_strip(self): > @@ -618,6 +623,8 @@ class Testvf_daemon(TestCase): >=20 > random_vlan =3D random.randint(1, MAX_VLAN - 1) > rx_vlans =3D [1, random_vlan, MAX_VLAN] > + if self.kdriver =3D=3D "ixgbe": > + self.vm0_testpmd.execute_cmd('vlan set filter on 0') I think vlan setting should be the same across NICs when using dpdk. Why on= ly ixgbe should enable vlan filter? > self.vm0_testpmd.execute_cmd('set fwd mac') > self.vm0_testpmd.execute_cmd('set verbose 1') > self.vm0_testpmd.execute_cmd('start') > @@ -632,6 +639,8 @@ class Testvf_daemon(TestCase): > time.sleep(3) > out =3D self.send_and_vlanstrip(self.vf0_mac,rx_vlan) > self.verify(rx_vlan not in out, "Failed to disable strip > vlan!!!") > + if self.kdriver =3D=3D "ixgbe": > + self.vm0_testpmd.execute_cmd('vlan set filter off 0') >=20 >=20 > def test_vlan_filter(self): > -- > 1.9.3