From: "Liu, Yong" <yong.liu@intel.com>
To: "Zhu, ShuaiX" <shuaix.zhu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhu, ShuaiX" <shuaix.zhu@intel.com>
Subject: Re: [dts] [PATCH V1] tests/uni_pkt:Modify the letter case.
Date: Tue, 27 Mar 2018 07:23:25 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62FCB537@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1522112424-97796-1-git-send-email-shuaix.zhu@intel.com>
Shuai,
NIC names were assigned in settings module, suite should exactly use the same name. You can remove lower function and just use NIC family name like "fortpark".
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Tuesday, March 27, 2018 9:00 AM
> To: dts@dpdk.org
> Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/uni_pkt:Modify the letter case.
>
> Because self.nic. lower () changes the network card name to lowercase,
> causing the network card name to not match with self.nic.lower().
>
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
> tests/TestSuite_uni_pkt.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_uni_pkt.py b/tests/TestSuite_uni_pkt.py
> index e11b482..db065eb 100644
> --- a/tests/TestSuite_uni_pkt.py
> +++ b/tests/TestSuite_uni_pkt.py
> @@ -115,7 +115,7 @@ class TestUniPacket(TestCase):
> """
> checked that whether L3 and L4 packet can be normally detected.
> """
> - if "fortville" in self.nic.lower() or "fortpark_TLV" in
> self.nic.lower():
> + if "fortville" in self.nic.lower() or "fortpark_tlv" in
> self.nic.lower():
> outerL4Type = "L4_NONFRAG"
> ipv4_default_packet_type = ["L2_ETHER", "L3_IPV4_EXT_UNKNOWN"]
> elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
> @@ -146,7 +146,7 @@ class TestUniPacket(TestCase):
> """
> checked that whether IPv6 and L4 packet can be normally detected.
> """
> - if "fortville" in self.nic.lower() or "fortpark_TLV" in
> self.nic.lower():
> + if "fortville" in self.nic.lower() or "fortpark_tlv" in
> self.nic.lower():
> outerL4Type = "L4_NONFRAG"
> ipv6_default_packet_type = ["L2_ETHER", "L3_IPV6_EXT_UNKNOWN"]
> elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
> --
> 1.9.3
prev parent reply other threads:[~2018-03-27 7:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 1:00 zhu,shuai
2018-03-27 7:23 ` Liu, Yong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62FCB537@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=shuaix.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).