[dts] [PATCH V1] tests/uni_pkt:Modify the letter case.

[dts] [PATCH V1] tests/uni_pkt:Modify the letter case.

[zhu,shuai]

Because self.nic. lower () changes the network card name to lowercase, causing the network card name to not match with self.nic.lower().

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_uni_pkt.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_uni_pkt.py b/tests/TestSuite_uni_pkt.py
index e11b482..db065eb 100644
--- a/tests/TestSuite_uni_pkt.py
+++ b/tests/TestSuite_uni_pkt.py
@@ -115,7 +115,7 @@ class TestUniPacket(TestCase):
         """
         checked that whether L3 and L4 packet can be normally detected.
         """
-        if "fortville" in self.nic.lower() or "fortpark_TLV" in self.nic.lower():
+        if "fortville" in self.nic.lower() or "fortpark_tlv" in self.nic.lower():
             outerL4Type = "L4_NONFRAG"
             ipv4_default_packet_type = ["L2_ETHER", "L3_IPV4_EXT_UNKNOWN"]
         elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
@@ -146,7 +146,7 @@ class TestUniPacket(TestCase):
         """
         checked that whether IPv6 and L4 packet can be normally detected.
         """
-        if "fortville" in self.nic.lower() or "fortpark_TLV" in self.nic.lower():
+        if "fortville" in self.nic.lower() or "fortpark_tlv" in self.nic.lower():
             outerL4Type = "L4_NONFRAG"
             ipv6_default_packet_type = ["L2_ETHER", "L3_IPV6_EXT_UNKNOWN"]
         elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
-- 
1.9.3

Re: [dts] [PATCH V1] tests/uni_pkt:Modify the letter case.

[Liu, Yong]

Shuai,
NIC names were assigned in settings module, suite should exactly use the same name. You can remove lower function and just use NIC family name like "fortpark".
 
Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Tuesday, March 27, 2018 9:00 AM
> To: dts@dpdk.org
> Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/uni_pkt:Modify the letter case.
> 
> Because self.nic. lower () changes the network card name to lowercase,
> causing the network card name to not match with self.nic.lower().
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_uni_pkt.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_uni_pkt.py b/tests/TestSuite_uni_pkt.py
> index e11b482..db065eb 100644
> --- a/tests/TestSuite_uni_pkt.py
> +++ b/tests/TestSuite_uni_pkt.py
> @@ -115,7 +115,7 @@ class TestUniPacket(TestCase):
>          """
>          checked that whether L3 and L4 packet can be normally detected.
>          """
> -        if "fortville" in self.nic.lower() or "fortpark_TLV" in
> self.nic.lower():
> +        if "fortville" in self.nic.lower() or "fortpark_tlv" in
> self.nic.lower():
>              outerL4Type = "L4_NONFRAG"
>              ipv4_default_packet_type = ["L2_ETHER", "L3_IPV4_EXT_UNKNOWN"]
>          elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
> @@ -146,7 +146,7 @@ class TestUniPacket(TestCase):
>          """
>          checked that whether IPv6 and L4 packet can be normally detected.
>          """
> -        if "fortville" in self.nic.lower() or "fortpark_TLV" in
> self.nic.lower():
> +        if "fortville" in self.nic.lower() or "fortpark_tlv" in
> self.nic.lower():
>              outerL4Type = "L4_NONFRAG"
>              ipv6_default_packet_type = ["L2_ETHER", "L3_IPV6_EXT_UNKNOWN"]
>          elif "niantic" in self.nic.lower() or "i350" in self.nic.lower():
> --
> 1.9.3