From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id A8E1DAA9E for ; Tue, 27 Mar 2018 09:23:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2018 00:23:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,366,1517904000"; d="scan'208";a="27849428" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 27 Mar 2018 00:23:28 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 27 Mar 2018 00:23:27 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 27 Mar 2018 00:23:27 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.235]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.108]) with mapi id 14.03.0319.002; Tue, 27 Mar 2018 15:23:25 +0800 From: "Liu, Yong" To: "Zhu, ShuaiX" , "dts@dpdk.org" CC: "Zhu, ShuaiX" Thread-Topic: [dts] [PATCH V1] tests/uni_pkt:Modify the letter case. Thread-Index: AQHTxWbqz5WcEwKLCkK/paXQXlYvjKPjlvRw Date: Tue, 27 Mar 2018 07:23:25 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62FCB537@SHSMSX103.ccr.corp.intel.com> References: <1522112424-97796-1-git-send-email-shuaix.zhu@intel.com> In-Reply-To: <1522112424-97796-1-git-send-email-shuaix.zhu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGE1OGE4YjItZjYxNi00Y2RmLWJlMzktNzI2MDRhMGYwYTE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJ0d05cL09lclwvZ0VIVnZJOVwvZU15WkI3WkdsQ2hHeFRKSFVVeFkzdVpjRVJZWFhBaytxVXp3dzRkYmNobllKR29yIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/uni_pkt:Modify the letter case. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 07:23:30 -0000 Shuai, NIC names were assigned in settings module, suite should exactly use the sa= me name. You can remove lower function and just use NIC family name like "f= ortpark". =20 Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai > Sent: Tuesday, March 27, 2018 9:00 AM > To: dts@dpdk.org > Cc: Zhu, ShuaiX > Subject: [dts] [PATCH V1] tests/uni_pkt:Modify the letter case. >=20 > Because self.nic. lower () changes the network card name to lowercase, > causing the network card name to not match with self.nic.lower(). >=20 > Signed-off-by: zhu,shuai > --- > tests/TestSuite_uni_pkt.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/tests/TestSuite_uni_pkt.py b/tests/TestSuite_uni_pkt.py > index e11b482..db065eb 100644 > --- a/tests/TestSuite_uni_pkt.py > +++ b/tests/TestSuite_uni_pkt.py > @@ -115,7 +115,7 @@ class TestUniPacket(TestCase): > """ > checked that whether L3 and L4 packet can be normally detected. > """ > - if "fortville" in self.nic.lower() or "fortpark_TLV" in > self.nic.lower(): > + if "fortville" in self.nic.lower() or "fortpark_tlv" in > self.nic.lower(): > outerL4Type =3D "L4_NONFRAG" > ipv4_default_packet_type =3D ["L2_ETHER", "L3_IPV4_EXT_UNKNO= WN"] > elif "niantic" in self.nic.lower() or "i350" in self.nic.lower()= : > @@ -146,7 +146,7 @@ class TestUniPacket(TestCase): > """ > checked that whether IPv6 and L4 packet can be normally detected= . > """ > - if "fortville" in self.nic.lower() or "fortpark_TLV" in > self.nic.lower(): > + if "fortville" in self.nic.lower() or "fortpark_tlv" in > self.nic.lower(): > outerL4Type =3D "L4_NONFRAG" > ipv6_default_packet_type =3D ["L2_ETHER", "L3_IPV6_EXT_UNKNO= WN"] > elif "niantic" in self.nic.lower() or "i350" in self.nic.lower()= : > -- > 1.9.3