test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Liu, Yong" <yong.liu@intel.com>
To: "Han, YingyaX" <yingyax.han@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Lu, PeipeiX" <peipeix.lu@intel.com>
Subject: Re: [dts] [PATCH V1] tests/ieee1588: fix ieee1588 failed
Date: Thu, 29 Mar 2018 02:35:54 +0000	[thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62FCD598@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1522219745-102043-1-git-send-email-yingyax.han@intel.com>

Hi Yingya,
Just for IEEE1588 suite, I think only DEV_RX_OFFLOAD_TIMESTAMP (0x00004000) is needed. 
Enabling too much Tx offloaing flags will cause confusion.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya
> Sent: Wednesday, March 28, 2018 2:49 PM
> To: dts@dpdk.org
> Cc: Lu, PeipeiX <peipeix.lu@intel.com>
> Subject: [dts] [PATCH V1] tests/ieee1588: fix ieee1588 failed
> 
> From: "lu,peipei" <peipeix.lu@intel.com>
> 
> IEEE1588 PTP V2 SYNC Message filtered by hardware need to set tx offloads.
> 
> Signed-off-by: lu,peipei <peipeix.lu@intel.com>
> ---
>  tests/TestSuite_ieee1588.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
> index d9a7b3a..eb7645f 100644
> --- a/tests/TestSuite_ieee1588.py
> +++ b/tests/TestSuite_ieee1588.py
> @@ -59,7 +59,7 @@ class TestIeee1588(TestCase):
>          self.dut.build_install_dpdk(self.target)
> 
>          self.pmdout = PmdOutput(self.dut)
> -        self.pmdout.start_testpmd("Default")
> +        self.pmdout.start_testpmd("Default","--tx-offloads=0x8ffe")
> 
>      def set_up(self):
>          """
> --
> 1.9.3

  reply	other threads:[~2018-03-29  2:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28  6:49 han,yingya
2018-03-29  2:35 ` Liu, Yong [this message]
2018-06-05  6:32 lu,peipei
2018-06-11  5:52 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E62FCD598@SHSMSX103.ccr.corp.intel.com \
    --to=yong.liu@intel.com \
    --cc=dts@dpdk.org \
    --cc=peipeix.lu@intel.com \
    --cc=yingyax.han@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).