From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8D78F1BA68 for ; Tue, 10 Apr 2018 03:29:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2018 18:29:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,429,1517904000"; d="scan'208";a="31456888" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 09 Apr 2018 18:29:29 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Apr 2018 18:29:29 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 9 Apr 2018 18:29:22 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.151]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.149]) with mapi id 14.03.0319.002; Tue, 10 Apr 2018 09:29:20 +0800 From: "Liu, Yong" To: "Han, YingyaX" , "dts@dpdk.org" CC: "Han, YingyaX" Thread-Topic: [dts] [PATCH V1]tests/userspace_ethtool: fix FVL stats issue Thread-Index: AQHTxzGa/qHiWmmw30aUJwCWO1I19aP5RxrQ Date: Tue, 10 Apr 2018 01:29:21 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E62FFCD2A@SHSMSX103.ccr.corp.intel.com> References: <1522309442-103581-1-git-send-email-yingyax.han@intel.com> In-Reply-To: <1522309442-103581-1-git-send-email-yingyax.han@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjJlYjk0Y2UtNGQxYi00MjQ0LThkY2YtZmYyZTRkNjBiYjdlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJcL2dtbEFOR0ZTZG5DelRPT1k5Tm1aMnpUYmQ4VXhzTExYNDJFNzVVQXJUczlISkpTcE9NUmt1citybzI4aUhzYSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1]tests/userspace_ethtool: fix FVL stats issue X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 01:29:32 -0000 Yingya, One comments below. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya > Sent: Thursday, March 29, 2018 3:44 PM > To: dts@dpdk.org > Cc: Han, YingyaX > Subject: [dts] [PATCH V1]tests/userspace_ethtool: fix FVL stats issue >=20 > FVL port statistic is retrieved from register. > Those filtered packets still will be calculated in. > Signed-off-by: han,yingya > --- > tests/TestSuite_userspace_ethtool.py | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) >=20 > diff --git a/tests/TestSuite_userspace_ethtool.py > b/tests/TestSuite_userspace_ethtool.py > index 84b1f1e..44bac01 100644 > --- a/tests/TestSuite_userspace_ethtool.py > +++ b/tests/TestSuite_userspace_ethtool.py > @@ -443,7 +443,11 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > pkt.send_pkt(tx_port=3Dintf) > time.sleep(2) > rx_pkts_wrong, _ =3D self.strip_portstats(port) > - self.verify(rx_pkts_wrong =3D=3D rx_pkts, "Failed to filter = Rx > vlan packet") > + if self.nic.startswith('fortville'): > + self.verify(rx_pkts_wrong =3D=3D rx_pkts + 1, "Failed to > filter Rx vlan packet") > + self.verify(_ =3D=3D rx_pkts, "Failed to filter Rx vlan > packet") > + else: > + self.verify(rx_pkts_wrong =3D=3D rx_pkts, "Failed to fil= ter > Rx vlan packet") Since transmitted packets number can be used to track the number of actuall= y received packets, Why not just use that one? Basic vlan feature has been covered in vlan suit= e, so I think We can simplify the problem here.=20 >=20 > # remove vlan > self.dut.send_expect("vlan %d del %d" % (index, vlan), > "EthApp>") > @@ -452,7 +456,11 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > pkt.send_pkt(tx_port=3Dintf) > time.sleep(2) > rx_pkts_del, _ =3D self.strip_portstats(port) > - self.verify(rx_pkts_del =3D=3D rx_pkts, "Failed to remove Rx= vlan > filter") > + if self.nic.startswith('fortville'): > + self.verify(rx_pkts_del =3D=3D rx_pkts_wrong + 1, "Faile= d to > filter Rx vlan packet") > + self.verify(_ =3D=3D rx_pkts, "Failed to filter Rx vlan > packet") > + else: > + self.verify(rx_pkts_del =3D=3D rx_pkts, "Failed to filte= r Rx > vlan packet") >=20 > self.dut.send_expect("quit", "# ") > self.dut.send_expect("sed -i -e '/hw_vlan_filter=3D1;$/d' %s" % > main_file, "# ") > -- > 1.9.3