From: "Liu, Yong" <yong.liu@intel.com>
To: "Zhao, MeijuanX" <meijuanx.zhao@intel.com>,
"dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] tests/vf daemon : open vf filter
Date: Fri, 25 May 2018 09:07:36 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E6304B4E1@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <9866F1E5CE768A45B24F6603C6EF54DE01354482@shsmsx102.ccr.corp.intel.com>
Sorry, I missed that. Patch also applied in.
Thanks,
Marvin
> -----Original Message-----
> From: Zhao, MeijuanX
> Sent: Friday, May 25, 2018 4:54 PM
> To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/vf daemon : open vf filter
>
> test_vlan_filter script has vlan filter set
>
> -----Original Message-----
> From: Liu, Yong
> Sent: Friday, May 25, 2018 4:50 PM
> To: Zhao, MeijuanX <meijuanx.zhao@intel.com>; dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/vf daemon : open vf filter
>
> Meijuan,
> Since vlan filter setting is the prerequisite for vlan strip and filter,
> why only vlan_strip case added this setting?
> Is it also needed for test_vlan_filter case?
>
> Thanks,
> Marvin
>
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> > Sent: Wednesday, May 23, 2018 2:42 PM
> > To: dts@dpdk.org
> > Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> > Subject: [dts] [PATCH V1] tests/vf daemon : open vf filter
> >
> > before set rx_vlan add command, need enable vf filter, before v18.02,
> > vf filter default is enable
> >
> > Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> > ---
> > tests/TestSuite_vf_daemon.py | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/TestSuite_vf_daemon.py
> > b/tests/TestSuite_vf_daemon.py index b1ad522..fddfb98 100644
> > --- a/tests/TestSuite_vf_daemon.py
> > +++ b/tests/TestSuite_vf_daemon.py
> > @@ -622,6 +622,7 @@ class Testvf_daemon(TestCase):
> > self.vm0_testpmd.execute_cmd('set verbose 1')
> > self.vm0_testpmd.execute_cmd('start')
> > for rx_vlan in rx_vlans:
> > + self.vm0_testpmd.execute_cmd('vlan set filter on 0')
> > self.vm0_testpmd.execute_cmd('rx_vlan add %s 0' % rx_vlan)
> > self.dut_testpmd.execute_cmd('set vf vlan stripq 0 0 off')
> > time.sleep(3)
> > @@ -632,7 +633,7 @@ class Testvf_daemon(TestCase):
> > time.sleep(3)
> > out = self.send_and_vlanstrip(self.vf0_mac,rx_vlan)
> > self.verify(rx_vlan not in out, "Failed to disable strip
> > vlan!!!")
> > -
> > + self.vm0_testpmd.execute_cmd('vlan set filter off 0')
> >
> > def test_vlan_filter(self):
> > """
> > --
> > 1.9.3
next prev parent reply other threads:[~2018-05-25 9:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 6:41 zhao,meijuan
2018-05-25 8:50 ` Liu, Yong
2018-05-25 8:54 ` Zhao, MeijuanX
2018-05-25 9:07 ` Liu, Yong [this message]
2018-05-25 9:26 zhao,meijuan
2018-05-28 13:30 ` Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E6304B4E1@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=dts@dpdk.org \
--cc=meijuanx.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).