From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 0D70C1E39D for ; Mon, 11 Jun 2018 07:07:25 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jun 2018 22:07:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,500,1520924400"; d="scan'208";a="58169335" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 10 Jun 2018 22:07:24 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 10 Jun 2018 22:07:24 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 10 Jun 2018 22:07:23 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.51]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.82]) with mapi id 14.03.0319.002; Mon, 11 Jun 2018 13:07:21 +0800 From: "Liu, Yong" To: "Zhao, MeijuanX" , "dts@dpdk.org" CC: "Zhao, MeijuanX" Thread-Topic: [dts] [PATCH V1] tests/vf daemon : add vlan filter Thread-Index: AQHT9xzC+89+NMfWYE2ImDFYSS0VpKRalOpw Date: Mon, 11 Jun 2018 05:07:21 +0000 Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E630C16F4@SHSMSX103.ccr.corp.intel.com> References: <1527578148-30451-1-git-send-email-meijuanx.zhao@intel.com> In-Reply-To: <1527578148-30451-1-git-send-email-meijuanx.zhao@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjZkZTEwMzItNTNlMC00NDI4LWEwNzMtNmU5YWEzMTljY2ZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMXhJMGRoaUp0bEVCalo3bGx5NE10SGI0Q3htUXJCc3R3Z01TS1lPbEJBZUdmM0F3bUFVTzlyRmFmN202RCs5TyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/vf daemon : add vlan filter X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 05:07:26 -0000 Meijuan, I known that maybe some issue in the driver. Could you please also= add some notes in the code? As enabling something before disabling look w= eird. Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan > Sent: Tuesday, May 29, 2018 3:16 PM > To: dts@dpdk.org > Cc: Zhao, MeijuanX > Subject: [dts] [PATCH V1] tests/vf daemon : add vlan filter >=20 > Ethdev layer doesn't know ixgbe PF PMD enable VLAN filter when it hosts > any VF. > The first "vlan set filter off 0" on PF doesn't take effect as ethdev > layer think > vlan filter isn't enabled on PMD. Adding "vlan set filter on 0" to align > the VLAN > filter switch in ethdev layer with that in PMD, and also make the first > "vlan set filter off 0" effective on PF. >=20 > Signed-off-by: zhao,meijuan > --- > tests/TestSuite_vf_daemon.py | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py > index 56fc4be..4ad4098 100644 > --- a/tests/TestSuite_vf_daemon.py > +++ b/tests/TestSuite_vf_daemon.py > @@ -576,6 +576,7 @@ class Testvf_daemon(TestCase): > if self.kdriver =3D=3D "i40e": > self.dut_testpmd.execute_cmd('set vf vlan stripq 0 0 off') > else: > + self.dut_testpmd.execute_cmd('vlan set filter on 0') > self.dut_testpmd.execute_cmd('vlan set filter off 0') > self.dut_testpmd.execute_cmd('vlan set strip off 0') > self.vm0_testpmd.execute_cmd('vlan set strip off 0') > -- > 1.9.3